[#25924] - Delete wrong check for the no download message
- Fixed in Code Base
- 19 Aug 2019
- Medium
- Build: staging
- # 25924
- Diff
- zero-24:fixNoDownloadCondition
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25827
Summary of Changes
Make sure no download message is displayed in any case when the download URL is not set
Testing Instructions
- install 3.9.12-dev (https://developer.joomla.org/nightlies/Joomla_3.9.12-dev-Development-Full_Package.zip)
- apply this custom update server: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
- try to get an update
- see the errors from #25827
- apply this patch
- check for updates again
- no download message is displayed
Expected result
No download message is displayed.
Actual result
PHP Notice: Undefined property: Joomla\CMS\Updater\Update::$downloadurl in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 34
PHP Notice: Trying to get property '_data' of non-object in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 34
PHP Notice: Undefined property: Joomla\CMS\Updater\Update::$downloadurl in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 35
PHP Notice: Trying to get property '_data' of non-object in \administrator\components\com_joomlaupdate\views\default\tmpl\default_reinstall.php on line 35
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
ha :D Fixed it is: https://www.jah-tz.de/downloads/core/nightlies/next_minor_list.xml
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25924.
Hint for other testers: You can also test with current staging on a cloned GitHub repo, no need do download and install 3.9.12-dev nightly build.
Thanks for your test @richard67 and yes staging works too but is not required
Yes, whatever is easier because available.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25924.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
Thank you for bringing some love to the Joomla update system.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-19 09:36:04 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
?
|
||
@zero-24 URL of custom update server missing in description.