? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Aug 2019

Pull Request for Issue #25852

Summary of Changes

As title says.
Also corrects RTL display (Needs more work as some css are not needed any more or are in px)
Basically changing width from 15.625rem to 18rem

Before patch

LTR
Screen Shot 2019-08-17 at 17 25 42

RTL
Screen Shot 2019-08-17 at 17 25 21

After patch

LTR
Screen Shot 2019-08-17 at 17 19 13

RTL
Screen Shot 2019-08-17 at 17 22 48


@chmst
@coolcat-creations

I have absolutely no idea why 15.625rem had been chosen for this sidebar width.
Therefore my proposal here does solve the issue but may have to be completed.

avatar infograf768 infograf768 - open - 17 Aug 2019
avatar infograf768 infograf768 - change - 17 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2019
Category Administration Templates (admin)
avatar infograf768 infograf768 - change - 17 Aug 2019
The description was changed
avatar infograf768 infograf768 - edited - 17 Aug 2019
avatar infograf768 infograf768 - change - 17 Aug 2019
The description was changed
avatar infograf768 infograf768 - edited - 17 Aug 2019
avatar richard67 richard67 - test_item - 17 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 17 Aug 2019

I have tested this item successfully on 3bb9eba


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25922.

avatar infograf768 infograf768 - change - 18 Aug 2019
Labels Added: ?
avatar richard67 richard67 - test_item - 18 Aug 2019 - Tested successfully
avatar richard67
richard67 - comment - 18 Aug 2019

I have tested this item successfully on b1cf511


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25922.

avatar wilsonge wilsonge - change - 18 Aug 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-18 10:51:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Aug 2019
avatar wilsonge wilsonge - merge - 18 Aug 2019
avatar wilsonge
wilsonge - comment - 18 Aug 2019

Thanks!

avatar wilsonge
wilsonge - comment - 18 Aug 2019

@infograf768 after this patch I now find on some pages (e.g. the languages installed page) that the table now goes off the edge of the screen

avatar infograf768
infograf768 - comment - 19 Aug 2019

after this patch I now find on some pages (e.g. the languages installed page) that the table now goes off the edge of the screen

Looking at it right now

avatar infograf768
infograf768 - comment - 19 Aug 2019

@wilsonge
can't reproduce here (FF)
Screen Shot 2019-08-19 at 10 39 09

avatar wilsonge
wilsonge - comment - 19 Aug 2019

Screenshot 2019-08-19 at 17 54 53

Screenshot 2019-08-19 at 17 55 49

If you compare the table position in the two images (before and after this patch)

avatar richard67
richard67 - comment - 19 Aug 2019

@wilsonge You mean top screenshot is after and bottom screenshot is before patch, right? I ask because you wrote vice versa.

avatar infograf768
infograf768 - comment - 19 Aug 2019

@wilsonge
your screenshots look weird. In the bottom one there is no dashboard icons.
Which browser are you using?

avatar chmst
chmst - comment - 19 Aug 2019

I had some similiar problems after this patch. npm i, clearing browser cache and finally a system restart helped for me.

avatar richard67
richard67 - comment - 19 Aug 2019

Thanks god only a system restart and not a formatting of the hard disk was necessary ;-)

avatar chmst
chmst - comment - 19 Aug 2019

:) the restart was an acciddent - but then all was fine

avatar brianteeman
brianteeman - comment - 19 Aug 2019

I can confirm what @wilsonge reported. It starts when the screen width is <1250px approx

image

avatar richard67
richard67 - comment - 19 Aug 2019

Yes, but there is a horizontal scrollbar shown, so nothing is really cut. George's screenshot did not show that scroll bar. @wilsonge Was your screenshot complete?

avatar wilsonge
wilsonge - comment - 20 Aug 2019

yes. in chrome on my macbook no scrollbar appears however i can scroll using the mouse anyhow to see the rest of the content. and yes your right order of screenshots got reversed - sorry

avatar infograf768
infograf768 - comment - 20 Aug 2019

I still consider, before and after this PR, that we have issues with this template when we modify the width of the screen. There are important gaps.

avatar infograf768
infograf768 - comment - 20 Aug 2019

Example with Chrome (Macintosh):
gaps

I do get the scroll bars though.

Add a Comment

Login with GitHub to post a comment