J4 Issue ?
avatar Scrabble96
Scrabble96
17 Aug 2019

Is your feature request related to a problem? Please describe.

I was looking to see if I could change a Fontawesome icon using the icons supplied in the J4.0 dev core and then discovered that the icon not available in Fontawesome 5.0 free version. I came across PR #24648, and posted the following there, but the PR was merged back in April, so I am opening a new issue:

The version of Fontawesome-free being used for J4.0 - version 5.0 - contains solid icons only. Any 'white' icons are now classed as 'light' and are only available in the Pro version.

In Joomla 3x, in the template editor directory tree, for example, the file icon is light and easily distinguishable at a glance from the folder icon:

J3-white-icons

In Joomla 4.0 dev, using Fontawesome version 5.0 free, they are all solid:

j4-solid-icons

You can see the difference on Fontawesome's pages for this icon here:

v4.7 free:
fontawesome-4 7-file-o

v5.0 free:
fontawesome-5 0-free-file

v5.0 Pro:
fontawesome-5 0-pro-file

Describe the solution you'd like

As well as using the latest version of Fontawesome in J4x core, keep Fontawesome 4.7 free in order to maintain access to light icons.

Additional context

avatar Scrabble96 Scrabble96 - open - 17 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 17 Aug 2019
avatar brianteeman
brianteeman - comment - 17 Aug 2019

No need to keep 4.7
Just need to add fa-regular as well as fa-solid

https://fontawesome.com/icons/file?style=regular

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 17 Aug 2019
avatar Scrabble96
Scrabble96 - comment - 17 Aug 2019

Thanks, @brianteeman
Will you do that?

I think that will also solve someone else's comment (can't find it now, though) that Fontawesome was all bold.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Aug 2019
Status New Discussion
avatar Scrabble96
Scrabble96 - comment - 18 Aug 2019

I have just discovered that not all icons available as fa-solid are available as fa-regular. Look at the code icon, for instance:

https://fontawesome.com/icons/code?style=regular

avatar Quy
Quy - comment - 18 Oct 2019

Please test PR #26631. Please close if you are ok with it.

PS: It does not make sense to maintain 2 versions.

avatar infograf768
infograf768 - comment - 19 Oct 2019

There is now a 5.11.2 version of fontawesome and using the regular would fit.
We just need to update as the version we use is quite old (5.9.0)

avatar Quy Quy - change - 8 Nov 2019
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2019-11-08 04:31:40
Closed_By Quy
avatar Quy Quy - close - 8 Nov 2019
avatar Quy
Quy - comment - 8 Nov 2019

See issue #27019 for request to upgrade to the latest version.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25915.

Add a Comment

Login with GitHub to post a comment