[#25909] - [4.0] a website menu is not role="menu"
- Fixed in Code Base
- 17 Aug 2019
- Medium
- Build: 4.0-dev
- # 25909
- Diff
- brianteeman:fri2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
I know it seems obvious to put role=menu, role=menuitem on our main menu but it is completely wrong. It is primarily for mimicking native OS menus not for navigation menus.
"Don’t Use ARIA Menu Roles for Site Nav" Adrian Roselli
"Don’t use ARIA menu semantics in navigation menu systems." inclusive design
Also it is wrong to have aria-haspopup to indicate the presence of a collapsed submenu - the correct attribute is aria-expanded=true/false
"Use aria-expanded to indicate the open/closed state of a button-activated navigation menu." inclusive design
This also fixes the two critical accessibility errors reported #25855
(PS there will be more PR to come as I check for other mis-uses of menu)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
I have tested this item
Reviewed code and the citations in the description, and tested that admin menu is still working as expected with this PR applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25909.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-17 09:50:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on ecb94ec
Reviewed code and the citations in the description, and tested that admin menu is still working as expected with this PR applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25909.