All new pr should use prepared statements, could you update this pr?

well yes, i could, but atm with this silly PR i just want to give to the few postgresql users the opportunity to play a little bit with j4, and help us to discover more bugs.....prepared statement conversion should be matter for another pr imho

At the moment only you and me did prepared statement conversion it should be a strict requirement on all pr touching a sql statement to convert it to use prepared statements.
There was a PLT motion about this topic:

https://volunteers.joomla.org/departments/production/reports/1013-production-dept-meeting-may-07-and-may-14-2019

If we don't required this we will still get new non prepared queries in patches.

i'd be more than happy if this motion have been taken in serious count before merging all & more,
but honestly this has not been happened....

At the moment only you and me did prepared statement conversion it should be a strict requirement on all pr touching a sql statement to convert it to use prepared statements.

Forcing unrelated changes into pull requests is exactly how you end up making pull requests more complex to review and more error prone. Converting existing queries should be pull requests of their own, writing new queries it is fine to mandate this. "You touched it so you need to change it" isn't a good workflow. Same goes with the random unrelated code style fixes that are commonly requested.

Forcing unrelated changes into pull requests is exactly how you end up making pull requests more complex to review and more error prone. Converting existing queries should be pull requests of their own, writing new queries it is fine to mandate this. "You touched it so you need to change it" isn't a good workflow. Same goes with the random unrelated code style fixes that are commonly requested.

This is partly true, but whats the better way? If no queries get updated to PS only if we find more then 2 people to do this job we will never finish this task.

Anyway I don't request to update all queries in this file only the one that get touched and tested afterwards. In a perfect would we would have tests at the same time, or the PR includes a test if non exists but as we all know tests are still missing all over the place.

It's ok for me if at least new queries use PS...

@alikon Will you work on this, make Harald happy with just changing those queries to PS which you have modified, and handle Hannes‘ comments? If so, ping me when ready for tests. But if you have little time: Shall I help with picking up that work and making PR for your repo so you just can merge with 1 click? If so, ping me and I will do later today.

@Hackwar Could you check if it ok now?

I have tested this item ✅ successfully on c484f45

I have tested this item ✅ successfully on c484f45

I have tested this item ✅ successfully on c484f45

@Quy RTC please ?

RTC

Thanks!