[#25833] - Get the runtime database driver for the configuration
- Fixed in Code Base
- 23 Aug 2019
- Medium
- Build: staging
- # 25833
- Diff
- twister65:3.9-dbtype
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
If the selected driver is mysql and we are on PHP 7 or greater, switch to the mysqli driver.
See PR #25729 and #25807
Summary of Changes
Get the actual database driver loaded at run time and fill in the dbtype parameter in the configuration form. You must save the configuration to update the file.
Testing Instructions
Expected result
Actual result
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_config |
If this is the same as the other PR for 3.10-dev then it doesn‘t need the other one. @wilsonge Is that right?
One pull request for a change, where the pull request is sent to the lowest active version branch the change applies to, and when merged the change merges forward as branches are merged up. Not that hard of a concept once people get used to it...
Ok, maybe I should not have asked George to confirm it, but I got used to people don't believe me so I ask for someone more "official" to confirm.
The question comes up often enough that I figured more than you and a couple others might know for sure by now
Anyway thanks for confirming and clarifying.
I have tested this item
Tested by code review. I've tested the same change for 4.0-dev before (PR #25729 ) with a real test, so I think it is enough to verify that it's the same.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833.
sure, done, and thanks i've missed that one
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-23 13:58:08 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
Thanks for preparing J3 for J4
If this is the same as the other PR for 3.10-dev then it doesn‘t need the other one. @wilsonge Is that right?