Pending

User tests: Successful: Unsuccessful:

avatar twister65
twister65
10 Aug 2019

Pull Request for deprecated database driver:
The PHP ext/mysql extension is removed in PHP 7, cannot use the mysql driver.
https://github.com/twister65/joomla-cms/blob/0346c2fc3668984b3b85ecb4a4941c6752c13f9c/libraries/joomla/database/driver.php#L257

See PR #25729

Summary of Changes

Get the actual database driver loaded at run time and fill in the dbtype parameter in the configuration form. You must save the configuration to update the file.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar twister65 twister65 - open - 10 Aug 2019
avatar twister65 twister65 - change - 10 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Aug 2019
Category Administration com_config
avatar richard67
richard67 - comment - 10 Aug 2019

I have tested this item successfully on 0346c2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

avatar richard67 richard67 - test_item - 10 Aug 2019 - Tested successfully
avatar viocassel
viocassel - comment - 12 Aug 2019

I have tested this item successfully on 0346c2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

avatar viocassel viocassel - test_item - 12 Aug 2019 - Tested successfully
avatar Quy Quy - change - 12 Aug 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

avatar Quy
Quy - comment - 12 Aug 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

avatar HLeithner
HLeithner - comment - 13 Aug 2019

Is there a reason not to merge it into 3.9?

avatar alikon
alikon - comment - 13 Aug 2019

for php < 7 ext/mysql is not deprecated iirc

avatar mbabker
mbabker - comment - 13 Aug 2019

for php < 7 ext/mysql is not deprecated iirc

The extension was deprecated as of PHP 5.5 and removed from PHP 7.

avatar richard67
richard67 - comment - 13 Aug 2019

Good question why it is not done in staging.

avatar twister65
twister65 - comment - 13 Aug 2019

Yes, this must also be done in staging:

if ($options['driver'] === 'mysql' && PHP_MAJOR_VERSION >= 7)

I'm doing a new PR for that.

avatar richard67
richard67 - comment - 13 Aug 2019

As there is a PR for staging, too, which does the same thing, this PR should be closed, otherwise they guys will have merge conflicts (which is not a big problem but a bit inconvenient).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

avatar Quy Quy - close - 13 Aug 2019
avatar Quy Quy - change - 13 Aug 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-08-13 17:04:33
Closed_By Quy

Add a Comment

Login with GitHub to post a comment