User tests: Successful: Unsuccessful:
Pull Request for new issue.
With pull request (PR) #21901 , columns checked_out_time
, publish_up
and publish_down
of database table #__modules
have been changed to use real null values instead of the stone-aged null date value. Again thanks @csthomas for that.
Later then new stuff from 3.9 was merged into 4.0-dev, which included modules mod_latestactions
and mod_privacy_dashboard
, but it was not adapted to the changes from the PR mentioned above.
The schema update provided with that PR already cares for updating existing records in the modules table, which will include the modules mentioned before, so this PR here only has to correct joomla.sql for new installations.
Code review.
Or if you have more time: Update a 3.9.x to 4.0 nightly and look up values for columns checked_out_time
, publish_up
and publish_down
in PhpMyAdmin or PhpPgAdmin (whatever db you have).
Then make a new installation of 4.0 nightly and check the same.
New installation and after update: Module table content consistent regarding null values for columns checked_out_time
, publish_up
and publish_down
. All records are inserted with real null values for these columns.
New installation: Module table content inconsistent regarding null values for columns checked_out_time
, publish_up
and publish_down
. All records are inserted with real null values for these columns, except of the last 2 records for modules mod_latestactions
and mod_privacy_dashboard
, those still use '0000-00-00 00:00:00'.
After update: See expected result.
None.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Installation Postgresql |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-10 09:44:47 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Sorry, I just notice this will create conflichs in the new backend template PR because this correction has also been made there.
@richard67 can you please change the language above to english :-)?
ahhh
Merged on code review. Thanks!