[#25802] - [4.0] Test data plugin
- Closed
- 10 Aug 2019
- Medium
- Build: 4.0-dev
- # 25802
- Diff
- brianteeman:sample-data
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
There are a lot of issues with this plugin - see #25777 .
Pull requests in smaller batches to make them easier to test
Summary of Changes
- All external links changed to https except for feeds.joomla.org which is not https :(
- Removed all references to the search component and module
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
Without this PR, installation of testing sample data completes.
With this PR, it stops at menu creation and issues 2 PHP notices:
PHP Notice: Undefined offset: 9 in /home/richard/lamp/public_html/joomla-cms-4.0-dev/plugins/sampledata/testing/testing.php on line 3142
PHP Notice: Undefined offset: 9 in /home/richard/lamp/public_html/joomla-cms-4.0-dev/plugins/sampledata/testing/testing.php on line 3153
It seems there are still child menu items of removed menu items, but I haven't found it yet.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25802.
If you want to remove an item completely, you best add some check in the foreach which continues the loop early if one of the removed articles would be created.
Or you renumber the remaining strings.
Simply removing the strings alone will not work.
Same for other items than articles, e.g. menu items, as it seems.
Maybe it would be easier not to remove content and menu items related to com_search but to replace conent by some article telling about the replacement of com_content by com_finder and where to find the external repository for those who still need it, similar to the notice recently at the developer pages.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-10 12:25:07 |
| Closed_By | ⇒ | brianteeman |
@brianteeman What happens with the articles belonging to those removed article titles and texts, e.g.
PLG_SAMPLEDATA_TESTING_SAMPLEDATA_CONTENT_ARTICLE_38_TITLE? As far as I understand testing.php, they still will be created because there is no check for emtpy title. Or will the model catch that when trying to save? If so, will that result in an error?