Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25800] - Make restore.php PHP 7.4 compatible

J3 Issue ?
avatar HLeithner
HLeithner
9 Aug 2019

Upgrading to @nikosdion current version of restore.php makes more trouble then fixing our version to support php 7.4.

See #25793

We need a PR to change indexed string accesses from {} to [] syntax

avatar HLeithner HLeithner - open - 9 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 9 Aug 2019
avatar HLeithner HLeithner - change - 9 Aug 2019
The description was changed
avatar HLeithner HLeithner - edited - 9 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Aug 2019
Labels Added: J3 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 9 Aug 2019
avatar richard67
richard67 - comment - 9 Aug 2019

There is PR #25782 . As far as I can see, @SharkyKZ had included restore.php and later reverted that due to upgrading. So if he again reverts the last commit, which is the revert commit, it should come back and all is fine. Or am I wrong?

avatar HLeithner
HLeithner - comment - 9 Aug 2019

Yes but should an own PR for better testing, because breaking the upgrade system could be a real pain. So if @SharkyKZ can create a new pr (and change the copyright information requested by nik) it would be great.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 9 Aug 2019

Closed as having Pull Request #25801

avatar franz-wohlkoenig franz-wohlkoenig - close - 9 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 9 Aug 2019
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-08-09 12:09:59
Closed_By ⇒ franz-wohlkoenig

Add a Comment

Login with GitHub to post a comment