I tried to update update from 3.9.2 to 3.9.11 with this restore.php but failed with "Invalid Login".

Also 3.9.11 to 3.9.11 doesn't work with the same error. Any idea?

I need to update the JavaScript on com_joomlaupdate. I hadn't realised that the restore.php you had was truly ancient. However, there are two problems with that.

1. There is no documentation on the code style for JavaScript. I already cancelled a planned contribution for J4 because I can't spend an infinite amount of time trying to guess the elusive coding standard or deal with the Hound's idiotic feedback which makes no sense.

2. During the update restore.php would be overwritten. At this point all future requests would fail because the JS already in the browser is out of date. The only way to deal with that is have users install a separate update to Joomla Update BEFORE updating Joomla itself. This is something we had to do in the past for the same reason (when we added hardening to restore.php sometime around Joomla! 3.4 IIRC).

The latter issue is basically one of communication and you should be able to handle it. The first issue is, at the moment, a hard contribution block for me. If someone gives me instructions for automatically applying JS code style with phpStorm I can resume my contributions which require JavaScript changes. If you can't you either commit to accept my contributions despite JS code style errors OR you lose me as a contributor. Rule number 1 for keeping contributors is to not make them feel their time is not appreciated by the project.

I think it's best if you just modify your current restore.php for PHP 7.4 compatibility and add a header notice. I'm not touching Joomla's JS code with a 30-foot pole seeing what kind of things its JS coding style wants me to do.

Thank you for you try and I have the same opinion to make our restore.php php 7.4 compatible is a much safer and easier step then upgrading to your version.

@HLeithner What about @nikosdion 's request for some JS code style docs? Do you know where to address that issue? Or could we link to some Hound docs in our docs? I don't want this to be ignored because don't want to block him and others from contributing. We currently have a lack of JS experts - I am pretty sure not one.

Update: Ah, I see it's about PHP code style. But that doesn't change that we should not block people from contributing.