Labels |
Added:
?
|
yes - lets close it there and keep it all in one place
Labels |
Added:
J4 Issue
|
Status | New | ⇒ | Discussion |
added more issues
I had hoped to address these issues in individual PR to make it easier for testing. However thats not going to be possible because of the way the plugin is created. I'm not even sure some of the issues can be resolved eg getting the module id or the menu item id
Regarding bugs in the data. When I created the plugin, I didn't check if content is correct. I just took the existing data and converted it as best as I could. So yes, there can be corrupt data in it.
The IDs of the created items should all be stored in the user session. Of course you can only use the IDs from thing that are already inserted in previous steps. For example it is impossible to link to a menuitem from an article since articles are created before the menuitems are. That's a restriction we have to live with.
So none of the content items that use {loadmoduleid} can ever be made to work with this plugin as it is currently structured because the articles are created in step 3 & 4 but the modules are not created until step 8 ??
Yep, and the modules can't be created before the articles because they need them.
Except if you want to create the article and update it in a later step again with the correct module ID, that may work.
Maybe a plan would be to remove all of the articles and menu items that exist just to display the modules (and their associated modules) and if anyone takes the time to work out how to resolve the issue they can be re-added. The last thing we want is for people to use the test data and think that j4 is buggy because the test data is wrong.
?
I'd rather keep them in and fix them soonish. If you remove them, they will be gone for good.
Well someone else will have to do that as that time of code is still beyond me ;)
Just removing the {loadmoduleid} and references to menuitems from the articles should be fine. If the article doesn't make sense anymore, it can be deleted.
Honestly I doubt anyone will invest the time needed to fix this as imho it's not worth the effort. Except if you think the testing sample data should cover all possible aspects of the CMS.
The testing sampledata should not cover all aspects, but it should provide a setup for every frontend view of a component, all modules with at least one layout configuration, a bigger setup of com_content with the different possibilities and I'm thinking about adding an option to generate massive amounts of content, like 10k articles.
Creating some code to create that content is not complicated, just creating all that content is timeconsuming.
I'm thinking about adding an option to generate massive amounts of content, like 10k articles.
If I remember right, there exists already such an extension.
Com_overload
I guess that we can fix the module issue easily now that i think about it by using {loadmodule mod_type,the title,} instead of {loadmoduleid xxx}
Yep, that way it should work fine
Yes, com_overload is there, but as far as I can see, hasn't been touched in a long time. Considering also that the author just recently announced that he does not want to see his code in Joomla, I'm not confident to promote that and rather see if we can role something like that ourselfs.
Make a PR to his repo if it needs to be improved. It doesn't need to be Joomla code.
updated to mark 2 as complete
Please add step 4 failing due to maximum execution time of 30 seconds exceeded.
Please read this comment. Are you testing on XAMPP with PHP 7.3.9 and 10.4.6-MariaDB?
updated the list
Status | Discussion | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-07 17:03:45 |
Closed_By | ⇒ | brianteeman |
Are these now all fixed?
no one seems remotely interested in it
Status | Closed | ⇒ | New |
Closed_Date | 2020-04-07 17:03:45 | ⇒ | |
Closed_By | brianteeman | ⇒ |
Maybe no one will be interested in the new 5 issues either... /facepalm
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-02-01 23:08:32 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
No Code Attached Yet
Removed: ? |
Same as #14019?