No Code Attached Yet J4 Issue
avatar brianteeman
brianteeman
4 Aug 2019
  • Add completed step (step9)
  • Fix the weird empty message referring to multilingual step 8
  • Update content to remove beez3, beez5, atomic references
  • Add privacy sample content
  • Add field sample content
  • Update module positions used for Cassiopeia
  • Remove references to search component and module
  • loadmoduleid has the wrong module ids in articles
  • modules in position none loaded in articles above are assigned to the wrong menu item
  • Deep Menu doesnt expand
  • Deep Menu - submenu items have the wrong parent - bug in lft rgt values ?
  • Update external links to https
  • step 4 failing due to maximum execution time of 30 seconds exceeded.
avatar brianteeman brianteeman - open - 4 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 4 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 4 Aug 2019
avatar brianteeman brianteeman - change - 4 Aug 2019
The description was changed
avatar brianteeman brianteeman - edited - 4 Aug 2019
avatar brianteeman brianteeman - change - 4 Aug 2019
The description was changed
avatar brianteeman brianteeman - edited - 4 Aug 2019
avatar Quy
Quy - comment - 4 Aug 2019

Add field sample content

Same as #14019?

avatar brianteeman
brianteeman - comment - 4 Aug 2019

yes - lets close it there and keep it all in one place

avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Aug 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 5 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 5 Aug 2019
Status New Discussion
avatar brianteeman brianteeman - change - 9 Aug 2019
The description was changed
avatar brianteeman brianteeman - edited - 9 Aug 2019
avatar brianteeman
brianteeman - comment - 9 Aug 2019

added more issues

avatar brianteeman brianteeman - change - 9 Aug 2019
The description was changed
avatar brianteeman brianteeman - edited - 9 Aug 2019
avatar brianteeman
brianteeman - comment - 10 Aug 2019

I had hoped to address these issues in individual PR to make it easier for testing. However thats not going to be possible because of the way the plugin is created. I'm not even sure some of the issues can be resolved eg getting the module id or the menu item id

avatar Bakual
Bakual - comment - 10 Aug 2019

Regarding bugs in the data. When I created the plugin, I didn't check if content is correct. I just took the existing data and converted it as best as I could. So yes, there can be corrupt data in it.

The IDs of the created items should all be stored in the user session. Of course you can only use the IDs from thing that are already inserted in previous steps. For example it is impossible to link to a menuitem from an article since articles are created before the menuitems are. That's a restriction we have to live with.

avatar brianteeman
brianteeman - comment - 10 Aug 2019

So none of the content items that use {loadmoduleid} can ever be made to work with this plugin as it is currently structured because the articles are created in step 3 & 4 but the modules are not created until step 8 ??

avatar Bakual
Bakual - comment - 10 Aug 2019

Yep, and the modules can't be created before the articles because they need them.
Except if you want to create the article and update it in a later step again with the correct module ID, that may work.

avatar brianteeman
brianteeman - comment - 10 Aug 2019

Maybe a plan would be to remove all of the articles and menu items that exist just to display the modules (and their associated modules) and if anyone takes the time to work out how to resolve the issue they can be re-added. The last thing we want is for people to use the test data and think that j4 is buggy because the test data is wrong.

?

avatar Hackwar
Hackwar - comment - 10 Aug 2019

I'd rather keep them in and fix them soonish. If you remove them, they will be gone for good.

avatar brianteeman
brianteeman - comment - 10 Aug 2019

Well someone else will have to do that as that time of code is still beyond me ;)

avatar Bakual
Bakual - comment - 11 Aug 2019

Just removing the {loadmoduleid} and references to menuitems from the articles should be fine. If the article doesn't make sense anymore, it can be deleted.
Honestly I doubt anyone will invest the time needed to fix this as imho it's not worth the effort. Except if you think the testing sample data should cover all possible aspects of the CMS.

avatar Hackwar
Hackwar - comment - 11 Aug 2019

The testing sampledata should not cover all aspects, but it should provide a setup for every frontend view of a component, all modules with at least one layout configuration, a bigger setup of com_content with the different possibilities and I'm thinking about adding an option to generate massive amounts of content, like 10k articles.

Creating some code to create that content is not complicated, just creating all that content is timeconsuming.

avatar Bakual
Bakual - comment - 11 Aug 2019

I'm thinking about adding an option to generate massive amounts of content, like 10k articles.

If I remember right, there exists already such an extension.

avatar brianteeman
brianteeman - comment - 11 Aug 2019

Com_overload

avatar brianteeman
brianteeman - comment - 11 Aug 2019

I guess that we can fix the module issue easily now that i think about it by using {loadmodule mod_type,the title,} instead of {loadmoduleid xxx}

avatar Bakual
Bakual - comment - 11 Aug 2019

Yep, that way it should work fine ?

avatar brianteeman
brianteeman - comment - 11 Aug 2019

doh - thats the way it is right now. Thats not the problem. The problem is that each of those modules is assigned to only appear on a selected menu item. By the looks of it they are all assigned to one menu item too high.

for example the menu module is assigned to display on the statistics page

image

avatar Hackwar
Hackwar - comment - 11 Aug 2019

Yes, com_overload is there, but as far as I can see, hasn't been touched in a long time. Considering also that the author just recently announced that he does not want to see his code in Joomla, I'm not confident to promote that and rather see if we can role something like that ourselfs.

avatar Bakual
Bakual - comment - 11 Aug 2019

Make a PR to his repo if it needs to be improved. It doesn't need to be Joomla code.

avatar SharkyKZ
SharkyKZ - comment - 29 Nov 2019

For point 2 test #27183 please.

avatar brianteeman brianteeman - change - 29 Nov 2019
The description was changed
avatar brianteeman brianteeman - edited - 29 Nov 2019
avatar brianteeman
brianteeman - comment - 29 Nov 2019

updated to mark 2 as complete

avatar Quy
Quy - comment - 5 Dec 2019

Please add step 4 failing due to maximum execution time of 30 seconds exceeded.

#26392 (comment)

avatar brianteeman
brianteeman - comment - 5 Dec 2019

@Quy I cannot replicate that

avatar Quy
Quy - comment - 5 Dec 2019

Please read this comment. Are you testing on XAMPP with PHP 7.3.9 and 10.4.6-MariaDB?

#26392 (comment)

avatar brianteeman brianteeman - change - 5 Dec 2019
The description was changed
avatar brianteeman brianteeman - edited - 5 Dec 2019
avatar brianteeman
brianteeman - comment - 5 Dec 2019

updated the list

avatar brianteeman brianteeman - change - 7 Apr 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-04-07 17:03:45
Closed_By brianteeman
avatar brianteeman brianteeman - close - 7 Apr 2020
avatar wilsonge
wilsonge - comment - 7 Apr 2020

Are these now all fixed?

avatar wilsonge wilsonge - change - 7 Apr 2020
The description was changed
avatar wilsonge wilsonge - edited - 7 Apr 2020
avatar brianteeman
brianteeman - comment - 7 Apr 2020

no one seems remotely interested in it

avatar wilsonge wilsonge - change - 7 Apr 2020
The description was changed
avatar wilsonge wilsonge - edited - 7 Apr 2020
avatar wilsonge wilsonge - change - 7 Apr 2020
Status Closed New
Closed_Date 2020-04-07 17:03:45
Closed_By brianteeman
avatar wilsonge wilsonge - reopen - 7 Apr 2020
avatar PhilETaylor
PhilETaylor - comment - 8 Jun 2020

Maybe no one will be interested in the new 5 issues either... /facepalm

avatar brianteeman brianteeman - change - 1 Feb 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-02-01 23:08:32
Closed_By brianteeman
Labels Added: No Code Attached Yet
Removed: ?
avatar brianteeman brianteeman - close - 1 Feb 2022

Add a Comment

Login with GitHub to post a comment