Pull Request for Issue #22817 .
This brings back Framework's Image library back to CMS.
Use Image library in some ways. E.g. set width and height options in Media Action - Resize
plugin,then use resize function in Media Manager.
Still works.
Yes.
Status | New | ⇒ | Discussion |
Category | ⇒ | Administration com_templates External Library Composer Change Libraries Front End Plugins Unit Tests |
Labels |
Added:
?
?
?
|
@dgrammatiko Media Action - Resize plugin does use Image class to resize images, if plugin parameters are set. I'll update testing instructions.
Resize plugin does use Image class to resize images if plugin parameters are set.
@SharkyKZ that's a huge thing then because no matter what dimensions you resize in the browser, those will be overridden from some parameters hidden in a plugin. I'm pretty sure the code exists only as a showcase that you can have plugins hooked on some PHP event but well I don't remember anymore. Maybe @laoneo remembers
@dgrammatiko the resize plugin has also some parameters to automatically resize an image on upload.
Unfortunately, our unittest images currently don't contain GD and thus all tests are actually not executing but just skipping. I'm going to try to fix that. Please don't merge before not all tests are executed.
The images have been changed. Please pull the latest changes from the base branch. The postgres system tests currently fail because of another PR that was merged prematurely, which shouldn't be an excuse to not wait for passing tests, but which should explain the problem.
Please again pull the latest changes, since the Postgres error has been fixed.
Image tests are now failing completely. GD is enabled but there appears to be no JPEG support and all MIME types are detected as image/jpeg
(using getimagesize()
).
Will have a look
Please again pull the latest changes. I've updated the docker images to include support for JPG in GD and I hope this works now. sigh
Thanks but no change :(
Got it.
Looks like image tests passed. Failures not related.
@SniperSister @zero-24 can someone have a careful look at rips please
where we are on this cc @release-joomla
Status | Discussion | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-15 12:38:29 |
Closed_By | ⇒ | wilsonge |
Thanks!
can you check Joomla\Image\Image::watermark()
Thanks!
That's not true, Media manager is handling ALL the edit plugins, at least in the edit view, in the client-side (browser)