? ? ?
avatar SharkyKZ
SharkyKZ
2 Aug 2019

Pull Request for Issue #22817 .

Summary of Changes

This brings back Framework's Image library back to CMS.

Testing Instructions

Use Image library in some ways. E.g. set width and height options in Media Action - Resize plugin,then use resize function in Media Manager.

Expected result

Still works.

Todo:

  • Tests

Documentation Changes Required

Yes.

avatar SharkyKZ SharkyKZ - open - 2 Aug 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 2 Aug 2019
Status New Discussion
avatar dgrammatiko
dgrammatiko - comment - 3 Aug 2019

Use Image library in some ways, e.g. use resize function in Media Manager.

That's not true, Media manager is handling ALL the edit plugins, at least in the edit view, in the client-side (browser)

avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2019
Category Administration com_templates External Library Composer Change Libraries Front End Plugins Unit Tests
avatar SharkyKZ SharkyKZ - change - 3 Aug 2019
Labels Added: ? ? ?
avatar SharkyKZ
SharkyKZ - comment - 3 Aug 2019

@dgrammatiko Media Action - Resize plugin does use Image class to resize images, if plugin parameters are set. I'll update testing instructions.

avatar SharkyKZ SharkyKZ - change - 3 Aug 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 3 Aug 2019
avatar dgrammatiko
dgrammatiko - comment - 3 Aug 2019

Resize plugin does use Image class to resize images if plugin parameters are set.

@SharkyKZ that's a huge thing then because no matter what dimensions you resize in the browser, those will be overridden from some parameters hidden in a plugin. I'm pretty sure the code exists only as a showcase that you can have plugins hooked on some PHP event but well I don't remember anymore. Maybe @laoneo remembers

avatar laoneo
laoneo - comment - 5 Aug 2019

@dgrammatiko the resize plugin has also some parameters to automatically resize an image on upload.

avatar SharkyKZ SharkyKZ - change - 14 Aug 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 14 Aug 2019
avatar SharkyKZ SharkyKZ - change - 14 Aug 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 14 Aug 2019
avatar Hackwar
Hackwar - comment - 19 Aug 2019

Unfortunately, our unittest images currently don't contain GD and thus all tests are actually not executing but just skipping. I'm going to try to fix that. Please don't merge before not all tests are executed.

avatar Hackwar
Hackwar - comment - 19 Aug 2019

The images have been changed. Please pull the latest changes from the base branch. The postgres system tests currently fail because of another PR that was merged prematurely, which shouldn't be an excuse to not wait for passing tests, but which should explain the problem.

avatar SharkyKZ
SharkyKZ - comment - 20 Aug 2019

@Hackwar Thanks.

avatar SharkyKZ SharkyKZ - change - 20 Aug 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 20 Aug 2019
avatar Hackwar
Hackwar - comment - 20 Aug 2019

Please again pull the latest changes, since the Postgres error has been fixed.

avatar SharkyKZ
SharkyKZ - comment - 20 Aug 2019

Image tests are now failing completely. GD is enabled but there appears to be no JPEG support and all MIME types are detected as image/jpeg (using getimagesize()).

avatar Hackwar
Hackwar - comment - 20 Aug 2019

Will have a look

avatar Hackwar
Hackwar - comment - 20 Aug 2019

Please again pull the latest changes. I've updated the docker images to include support for JPG in GD and I hope this works now. sigh

avatar SharkyKZ
SharkyKZ - comment - 20 Aug 2019

Thanks but no change :(

avatar Hackwar
Hackwar - comment - 20 Aug 2019

Got it.

avatar SharkyKZ
SharkyKZ - comment - 29 Aug 2019

Looks like image tests passed. Failures not related.

avatar SharkyKZ SharkyKZ - change - 29 Aug 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 29 Aug 2019
avatar wilsonge
wilsonge - comment - 24 Sep 2019

@SniperSister @zero-24 can someone have a careful look at rips please

avatar alikon
alikon - comment - 7 Dec 2019

where we are on this cc @release-joomla

avatar wilsonge wilsonge - change - 15 Jan 2020
Status Discussion Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-15 12:38:29
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Jan 2020
avatar wilsonge wilsonge - merge - 15 Jan 2020
avatar wilsonge
wilsonge - comment - 15 Jan 2020

Thanks!

avatar chnnst
chnnst - comment - 23 Dec 2020

can you check Joomla\Image\Image::watermark()

Thanks!

Add a Comment

Login with GitHub to post a comment