? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Jul 2019

Summary of Changes

Updates the tmpl for the consents view to match J4 standards and styles
Add name column
Add search by name filter
Rename "Created" column header to "Consented"

Testing Instructions

To test it will be easier if you have some data. These three rows should cover all the options - obviously replace jos_ with your own db prefix AND user_id with a valid id

INSERT INTO `jos_privacy_consents` (`id`, `user_id`, `state`, `created`, `subject`, `body`, `remind`, `token`) VALUES (1, 540, 1, '2019-07-01 19:36:00', 'title', 'body', 0, '');
INSERT INTO `jos_privacy_consents` (`id`, `user_id`, `state`, `created`, `subject`, `body`, `remind`, `token`) VALUES (2, 540, 0, '2018-06-01 12:01:00', 'title', 'body', 0, '');
INSERT INTO `jos_privacy_consents` (`id`, `user_id`, `state`, `created`, `subject`, `body`, `remind`, `token`) VALUES (3, 540, -1, '2019-07-01 07:16:00', 'title', 'body', 0, '');

Expected result

image

Other parts of com_privacy are beyond the scope of this PR

avatar brianteeman brianteeman - open - 30 Jul 2019
avatar brianteeman brianteeman - change - 30 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 30 Jul 2019
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 30 Jul 2019
Labels Added: ? ?
avatar 1apweb
1apweb - comment - 30 Jul 2019

I have tested this item successfully on 2c7508d

Hi, everything seems ok. But the drop-down menu Filter Option does not close for choices Status and Subjects.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25744.

avatar 1apweb 1apweb - test_item - 30 Jul 2019 - Tested successfully
7f42111 30 Jul 2019 avatar brianteeman cs
avatar richard67 richard67 - change - 30 Jul 2019
The description was changed
avatar joomla-cms-bot joomla-cms-bot - edited - 30 Jul 2019
avatar joomla-cms-bot joomla-cms-bot - edited - 30 Jul 2019
avatar richard67
richard67 - comment - 30 Jul 2019

I have tested this item successfully on 8147e99


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25744.

avatar richard67 richard67 - test_item - 30 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 30 Jul 2019

Hi, everything seems ok. But the drop-down menu Filter Option does not close for choices Status and Subjects.

I can confirm @1apweb ' s finding and can confirm that it happens with and without this PR in the same way.

avatar richard67
richard67 - comment - 30 Jul 2019

@brianteeman Is @1apweb ' s finding about filter drop down menu not closing worth a new issue? If so, will you write one or shall I do?

avatar brianteeman
brianteeman - comment - 30 Jul 2019

It's an old issue addressed by new template

avatar richard67
richard67 - comment - 30 Jul 2019

@1apweb Could you test again? There have been made changes since you've tested.

avatar Quy
Quy - comment - 1 Aug 2019

Under Filter Options dropdown:

  • change Created ascending/descending to Consented ascending/descending
  • add Name ascending/descending
avatar Quy
Quy - comment - 1 Aug 2019

Does #24188 apply here?

avatar brianteeman
brianteeman - comment - 1 Aug 2019

@Quy I hope not ;) From my reading of that it was only until @wilsonge had merged 3.9.0 - and he has

avatar brianteeman
brianteeman - comment - 1 Aug 2019

Changes requested by @Quy have been applied

avatar Quy
Quy - comment - 1 Aug 2019

I have tested this item successfully on eb90f8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25744.

avatar Quy
Quy - comment - 1 Aug 2019

I have tested this item successfully on eb90f8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25744.

avatar Quy Quy - test_item - 1 Aug 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Aug 2019

@1apweb can you please retest?

avatar wilsonge
wilsonge - comment - 1 Aug 2019

@Quy I hope not ;) From my reading of that it was only until @wilsonge had merged 3.9.0 - and he has

Correct. That issue is just open still so i can track my cleanup pile from the merges.

avatar alikon
alikon - comment - 4 Aug 2019

I have tested this item successfully on eb90f8b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25744.

avatar alikon alikon - test_item - 4 Aug 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Aug 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 4 Aug 2019

Status "Ready To Commit".

avatar brianteeman brianteeman - change - 4 Aug 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 5 Aug 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-08-05 12:46:17
Closed_By wilsonge
avatar wilsonge wilsonge - close - 5 Aug 2019
avatar wilsonge wilsonge - merge - 5 Aug 2019
avatar wilsonge
wilsonge - comment - 5 Aug 2019

Thanks!

avatar brianteeman
brianteeman - comment - 5 Aug 2019

Thanks

Add a Comment

Login with GitHub to post a comment