? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jul 2019

All fields with type=email also have a validate=email rule
This one field was missing the validation

avatar brianteeman brianteeman - open - 28 Jul 2019
avatar brianteeman brianteeman - change - 28 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2019
Category Administration com_contact com_redirect
avatar brianteeman brianteeman - change - 28 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2019
Category Administration com_contact com_redirect Administration com_contact
avatar richard67
richard67 - comment - 28 Jul 2019

I have tested this item successfully on 41867f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25733.

avatar richard67 richard67 - test_item - 28 Jul 2019 - Tested successfully
avatar dgrammatiko
dgrammatiko - comment - 28 Jul 2019

If you add a validate rule also means that the field should be required as it cannot(?) be empty. I don't know if this is the case here

avatar brianteeman
brianteeman - comment - 29 Jul 2019

@dgrammatiko no its not - test it and you will see

avatar wilsonge
wilsonge - comment - 29 Jul 2019

If you add a validate rule also means that the field should be required as it cannot(?) be empty

https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Form/Rule/EmailRule.php#L54-L60

If it's not required and empty then it passes just fine

avatar wilsonge wilsonge - change - 29 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-29 10:17:56
Closed_By wilsonge
avatar wilsonge wilsonge - close - 29 Jul 2019
avatar wilsonge wilsonge - merge - 29 Jul 2019
avatar wilsonge
wilsonge - comment - 29 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 29 Jul 2019

Thanks

avatar dgrammatiko
dgrammatiko - comment - 29 Jul 2019

@wilsonge I was referring to the js part not the php

avatar brianteeman
brianteeman - comment - 29 Jul 2019

@wilsonge as already mentioned numerous times - that code you refer to is not being used

Add a Comment

Login with GitHub to post a comment