? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Jul 2019

option=com_languages&view=languages had a title on the link and an identical tooltip (which was actually incorrect). This simple PR removes the tooltip

code review

avatar brianteeman brianteeman - open - 28 Jul 2019
avatar brianteeman brianteeman - change - 28 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Jul 2019
Category Administration com_languages
avatar richard67
richard67 - comment - 28 Jul 2019

I have tested this item successfully on e254cdf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25730.

avatar richard67 richard67 - test_item - 28 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 29 Jul 2019

I have tested this item ? unsuccessfully on e254cdf

As George mentioned in his comment to the code, the closing span has not been removed with this PR together with the opening one, which results in invalid html.

Seems I missed that when testing the first time.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25730.

avatar richard67 richard67 - test_item - 29 Jul 2019 - Tested unsuccessfully
avatar brianteeman brianteeman - change - 29 Jul 2019
Labels Added: ?
avatar richard67
richard67 - comment - 29 Jul 2019

I have tested this item successfully on 6bc99f1

Now it is ok. Removing the span does not result in any visible change.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25730.

avatar richard67 richard67 - test_item - 29 Jul 2019 - Tested successfully
avatar Quy
Quy - comment - 29 Jul 2019

I have tested this item successfully on 6bc99f1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25730.

avatar Quy Quy - test_item - 29 Jul 2019 - Tested successfully
avatar Quy Quy - change - 29 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25730.

avatar wilsonge wilsonge - change - 30 Jul 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 30 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-30 03:03:25
Closed_By wilsonge
avatar wilsonge wilsonge - close - 30 Jul 2019
avatar wilsonge wilsonge - merge - 30 Jul 2019
avatar wilsonge
wilsonge - comment - 30 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 30 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment