[#25724] - [4.0] use standard SQL - fix errors on postgresql
- Fixed in Code Base
- 31 Jul 2019
- Medium
- Build: 4.0-dev
- # 25724
- Diff
- alikon:patch-111
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue
use standard SQL
Summary of Changes
rewrite query in standard SQL instead of mysql dialect
- correct JOIN for syntax error at or near "WHERE"
- ERROR: CASE types character varying and numeric cannot be matched
Testing Instructions
Install latest 4.0-dev and populate data with sample testing plugin
go on frontpage
Expected result
see articles even in postgresql
Actual result
errors with postgresql
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content Plugins |
yes latest 4.0
Will test later in the afternoon CEST time.
@alikon If you find time, please fix the drone PCPCS errors.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25724.
| Labels |
Added:
?
|
||
@richard67 cs fixed..... when you have time...
I have tested this item
There are still errors with testing sample data on PostgreSQL, but they are not related to this PR, i.e. the errors are there with and without this PR:
- On MySQL, the article with title "Joomla! Testing" as 4 tags assigned, tags "2", "3", "4" and "5", but on PostgreSQL the same article has only 1 assigned, which is tag "2".
- When editing any article, a red popup alert "Error" is shown, telling only "An error has occurred.".
- When trying to save a new article, an SQL errors about null value for column with not null constraint is shown.
As I said, it seems not to be related to this PR.
I will make new issues for that, except @alikon tells me before that he wants to fix the one or other thing here in this PR, too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25724.
I have tested this item
There are still errors with testing sample data on PostgreSQL, but they are not related to this PR, i.e. the errors are there with and without this PR:
- On MySQL, the article with title "Joomla! Testing" as 4 tags assigned, tags "2", "3", "4" and "5", but on PostgreSQL the same article has only 1 assigned, which is tag "2".
- When editing any article, a red popup alert "Error" is shown, telling only "An error has occurred.".
- When trying to save a new article, an SQL errors about null value for column with not null constraint is shown.
As I said, it seems not to be related to this PR.
I will make new issues for that, except @alikon tells me before that he wants to fix the one or other thing here in this PR, too.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25724.
@richard67 thanks for testing
it should be always better to have 1 pr for 1 issue as a main rule
so i will be happy if free time permits me, to make a pr for any issue postgresql related (even not) that you'll submit (you know my mantra is to close issues as many as possible
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-31 19:01:14 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Testing instructions say “install latest staging” but I guess you mean “install latest 4.0-dev” since this PR is for 4.0-dev. If I am right, please correct.