[#25715] - [4.0] Changing checked_out_time from nulldate to real null value
- Closed
- 14 Oct 2019
- Medium
- Build: 4.0-dev
- # 25715
- Diff
- Hackwar:j4checkedout
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Since MySQL 8 does not support the 0000-00-00 00:00:00 default value anymore, we have to fix this properly and use a real null value instead. I was looking for some way to cut up the work in good chunks and for me it was along the lines of features. So the checkin feature is the first that I've tackled here. This should change all columns and the code to properly use the null value instead. The Postgres update code is untested as of yet.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_banners com_checkin com_tags Installation Libraries |
| Labels |
Added:
?
|
||
@wilsonge Would that mean it is for the complete table? In this case it might really need to extend this PR to other columns or make new ones by table for where it's not done yet.
@Hackwar I've successfully tested new install of 4.0-dev + this PR + changes from my PR #25658 with MySQL 8 and also with PostgreSQL. For testing updates I have a modified update package of last nightly build with changes from PR and my PR #25658, but this I haven't tested yet.
To you both: How shall we continue?
For testing update, modified update package of last nightly build + this PR + changes from my PR #25658 can be found here: https://test5.richard-fath.de/Joomla_4.0.0-alpha11-dev-Development-Update_Package__pr-25715.zip. Will test later.
Updating a feature like checkin over the complete code base is hard to test and then you have tido the same tests for publishedup/down and so on.
But in that case I think we'll find the null fields do not get updated and in that case i don't think you'll be able to uncheckout an article. This is why things were being done per component rather than per db field :)
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-14 18:18:42 |
| Closed_By | ⇒ | Quy |
Replaced by #26491 and #26490.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25715.
We're going to need to add this https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Table/Table.php#L125-L131 to affected tables I believe too