? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Jul 2019

Unless I am missing something, which is quite possible, then the font preview in com_templates is not a form and this PR removes the form related code from the preview.

To test this you will need to copy a font to your template folder. Once you have done that you should see the following preview when you click on the font

image

avatar brianteeman brianteeman - open - 24 Jul 2019
avatar brianteeman brianteeman - change - 24 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2019
Category Administration com_templates
avatar Quy
Quy - comment - 24 Jul 2019

Now clicking on the Close File button does not close the file.

avatar mbabker
mbabker - comment - 24 Jul 2019

Unless I am missing something, which is quite possible

Does the admin component view have a toolbar? If so, it has to be wrapped in a form, otherwise things don't work right. Basically, most of Joomla's JavaScript API relies on being able to submit a form.

avatar richard67
richard67 - comment - 26 Jul 2019

After reading the 2 comments above: Should this PR be closed? Or changed?

avatar brianteeman brianteeman - change - 19 Aug 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-08-19 22:52:19
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 19 Aug 2019

Add a Comment

Login with GitHub to post a comment