[#25696] - [4.0] Change duplicate label to span for extension name in extensions manager list view
- Fixed in Code Base
- 27 Jul 2019
- Medium
- Build: 4.0-dev
- # 25696
- Diff
- richard67:4.0-dev-fix-duplicate-label-extensions-manager
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25642 (comment) and #25642 (comment).
Summary of Changes
Change HTML element of the extension name from <label> to <span> in the extensions manager's list view because the check box to select the item is already a label for the same thing, and duplicate labels for same thing is invalid HTML.
See also the comment mentioned above as issue.
Testing Instructions
Inspect with your browser's developer tools the HTML of the extensions manager's list view.
Check the label element just before the check box and then the extension name for a particular extension.
Or validate the page and check for duplicate label errors.
Expected result
Only 1 label for the check box, which is the element before the check box, and the extension name is not another label for that.
Actual result
1 label for the check box, which is the element before the check box, and the extension name is another label for that.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25696.
I have tested this item
Should be correct with: <span tabindex="0">Banners
OT: I had to enter the verification code.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25696.
I have tested this item
Should be correct with: <span tabindex="0">Banners
OT: I had to enter the verification code.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25696.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25696.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25696.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-27 20:01:03 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks.
@Quy Done.