[#25691] - [4.0] Language strings in CLI
- Fixed in Code Base
- 23 Jul 2019
- Medium
- Build: 4.0-dev
- # 25691
- Diff
- brianteeman:mon2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Nothing major just tweaking the case and tense to be consistent on a few messages
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Screenshot for "After" seems not to be up to date.
possibly not
Possibly yes: It shows 'Cleans expired cache entries', but in code is 'Clean expired cache entries'. Just 1 example.
the code is the truth
I know, but correct testing instructions (including screenshots) are always good.
With the PR applied, the output is still database:export Exports the database.
I know, this PR did not touch that code, but the screenshot showed so, and now the output is still inconsistent.
Thats because its in the vendor folder and I need to submit that upstream
Ah, I see. Will you do that, submitt to upstream?
its already done
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25691.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25691.
The changes required upstream have been merged
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-23 17:32:25 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on bd0230c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25691.