[#25687] - [4.0] [plg_system_skipto] Simplify code
- Fixed in Code Base
- 23 Jul 2019
- Medium
- Build: 4.0-dev
- # 25687
- Diff
- SharkyKZ:j4/plgSystemSkipto
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Simplifies code by storing meaningful parameter values.
Testing Instructions
Apply patch.
Try different 'Site Section' options in plugin.
Test that selected section option is respected (plugin runs only on site, administrator or both based on option).
Expected result
Works like before.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I really would like to test that, but I don't see that skip to menu, neither in admin nor on site. Plugin is enabled. Am I doing something wrong?
I think you have to press Tab. Or maybe 0. If none of the keys work, just inspect the page's source code to check that assets are loaded on correct sections of the site. About the rest complain to Brain.
Ahh now I know what brian meant with "tabbing" in his description when he added that skipto thing. In a browser which has tabs I have expected something else. Will finish eating and then test your PR. Thanks for explaining.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25687.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25687.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25687.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-23 18:20:59 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on 3effe5a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25687.