? ? Pending

User tests: Successful: Unsuccessful:

avatar degobbis
degobbis
22 Jul 2019

Pull Request for Issue #25652 .

Testing Instructions

see #25628

avatar degobbis degobbis - open - 22 Jul 2019
avatar degobbis degobbis - change - 22 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jul 2019
Category Front End Plugins
avatar gogicomputers
gogicomputers - comment - 22 Jul 2019

I have tested this item successfully on 4bb2e3a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

avatar gogicomputers gogicomputers - test_item - 22 Jul 2019 - Tested successfully
avatar viocassel
viocassel - comment - 22 Jul 2019

I have tested this item successfully on 4bb2e3a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

avatar viocassel viocassel - test_item - 22 Jul 2019 - Tested successfully
avatar Quy Quy - change - 22 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 22 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

avatar HLeithner
HLeithner - comment - 22 Jul 2019

@laoneo can you have a look at this because i'm not quite confident with this.

avatar degobbis degobbis - change - 23 Jul 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 23 Jul 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-07-23 08:13:00
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 23 Jul 2019
avatar HLeithner HLeithner - change - 23 Jul 2019
Status Closed New
Closed_Date 2019-07-23 08:13:00
Closed_By HLeithner
Labels Removed: ?
avatar HLeithner HLeithner - change - 23 Jul 2019
Status New Pending
avatar HLeithner HLeithner - reopen - 23 Jul 2019
avatar laoneo
laoneo - comment - 23 Jul 2019

Me neither, pretty sure this will introduce a regression.

avatar degobbis
degobbis - comment - 24 Jul 2019

@laoneo Could you please describe in more detail why this would introduce a regression?
The only problem I still see are disabled fields which are also required, but we already have the problem and I can take care of that in a next step.

avatar degobbis
degobbis - comment - 25 Jul 2019

@laoneo @HLeithner I have restored the previous state, as I do not really fully understand when a default value is needed. The only adjustment now concerns what, according to the description, anyway should not be.
If the field is disabled, and the browser still sends data, then I will delete it again.
I hope now there should be no reason to hold back the fix.

avatar laoneo
laoneo - comment - 25 Jul 2019

@degobbis can't say exactly what, it is just so a feeling. It took a couple of iterations till we were on a stable state with all these readonly, disabled states and access level settings including the passed array. What I can remember is that we had issues with values not being present in the data array as they were needed to clear values, etc.

avatar degobbis
degobbis - comment - 25 Jul 2019

@laoneo However, we are currently receiving an error message because the values from disabled fields are still sent. With my fix, I'm only making sure that the described procedure of the Bowser is actually executed. Either way, the same result.

avatar degobbis
degobbis - comment - 25 Jul 2019

@gogicomputers @viocassel Could You please test my changes again?

avatar d4shoerncheN
d4shoerncheN - comment - 26 Jul 2019

I have tested this item successfully on 174136c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

avatar d4shoerncheN
d4shoerncheN - comment - 26 Jul 2019

I have tested this item successfully on 174136c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

avatar d4shoerncheN d4shoerncheN - test_item - 26 Jul 2019 - Tested successfully
avatar gogicomputers
gogicomputers - comment - 26 Jul 2019

I have tested this item successfully on 174136c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25682.

avatar gogicomputers gogicomputers - test_item - 26 Jul 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 26 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 26 Jul 2019

Status "Ready To Commit".

Thanks for tests.

avatar HLeithner HLeithner - change - 30 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-30 06:29:10
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 30 Jul 2019
avatar HLeithner HLeithner - merge - 30 Jul 2019
avatar HLeithner
HLeithner - comment - 30 Jul 2019

thx

Add a Comment

Login with GitHub to post a comment