[#25675] - [4.0] Logging in Debug plugin is broken
- Closed
- 8 Aug 2020
- Urgent
- Build: staging
- # 25675
Steps to reproduce the issue
Enable Debug System in Global Configuration.
Enable System - Debug plugin.
In plugin, enable Log Deprecated API.
Inspect the Debug bar.
Expected result
100s of deprecation messages.
Actual result
Only 1 message.
Additional comments
Caused by #20547 (CC @laoneo). At first glimpse this call could be moved from constructor to an event but I'm not sure if this is the correct solution, plus it might miss some messages this way:
joomla-cms/plugins/system/debug/debug.php
Line 186 in effa28d
joomla-cms-bot
- | Labels |
Added:
?
|
||
franz-wohlkoenig
- | Labels |
Added:
J4 Issue
|
||
| Title |
|
||||||
| Status | New | ⇒ | Discussion |
there are some other things which need to be changed.
I could not login this morning after updating a dev test site (which was set to debug) to latest -dev via eclipse and running npm ci.
Joomla\Plugin\System\Debug\Storage\FileStorage; not found.
After adding /use Joomla\Plugin\System\Debug\Storage\FileStorage; in
/plugins/system/debug/Storage/FileStorage.php
I could log in. Thereafter I commented that line and it worked fine again.
Hope it helps.
@laoneo Thanks.
@infograf768 You needed to delete the libraries/autoload_psr4.php file. Maybe we should have it regenerated automatically after updating Joomla!
| Status | Discussion | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-09-11 13:24:13 |
| Closed_By | ⇒ | franz-wohlkoenig |
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-09-11 13:24:13 | ⇒ | |
| Closed_By | franz-wohlkoenig | ⇒ |
| Labels |
Added:
?
|
||
| Priority | Medium | ⇒ | Urgent |
| Labels |
Removed:
?
|
||
Increasing priority as per guidelines for beta-blockers.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25675.
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Confirmed |
| Labels |
Removed:
?
|
||
| Labels |
Added:
?
|
||
wilsonge
- | Labels |
Added:
?
Removed: ? |
||
i would not add another issue, but also query explain is broken in the debug plugin as we are now quite converted all SQL to prepared statements
it can be better,
or wait ....
before to switch on this new thing maybe someone would had been to think a little bit more , we are losing a too much feature from j3 compared to j4 for what ? .... a more fancy display
your friendly complainer...
we are losing a too much feature from j3 compared to j4 for what ? .... a more fancy display
No, it not because fancy display, it because DB layer limitation.
Later I will open new issue with some explanation.
Wait, I will open new issue about database, then we can close this
Ok, thanks. No need to hurry, just ping me when done.
| Status | Confirmed | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-08-08 11:10:32 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: ? |
||
please don't get me wrong
i really appreciate your efforts
but we still miss something "Call Stack" for example
j3
j4
but we still miss something "Call Stack" for example
You have to activate Call Stack, Explain and Profile in the plugin first
| Labels |
Removed:
?
|
||
I will have a look on the debug plugin as there are some other things which need to be changed.