User tests: Successful: Unsuccessful:
Pull Request for Issue #25452 for staging.
Fix case in column type check of database schema checker for MySQL 8.
When you enter e.g. the SQL statement
SHOW COLUMNS IN #__extensions WHERE field = 'enabled' AND type = 'TINYINT(3)';
(using your db prefix of course and not
in PhpMyAdmin on a Joomla 3.9.10 or staging database, you will get a result in MySQL 5.7 but not in MySQL 8.
But when you enter
SHOW COLUMNS IN #__extensions WHERE field = 'enabled' AND UPPER(type) = 'TINYINT(3)';
you get a result on both MySQL versions.
In both cases type names are lowercase in the result, but on MySQL 8 the search seems to be case-sensitive, while it is case-insensitive e.g. on MySQL 5.7.
Result: See section "Actual result" below.
Result: See section "Expected result" below.
No database errors.
Database errors shown as described in issue #25452 , but when you check in the database and the schema update SQL mentioned in the error message, you will not see any reason because the data types match in all details those set by the schema update and also those in joomla.sql.
@breisig Did you already find time to test? If so, please mark your test result in the Joomla CMS issue tracker at https://issues.joomla.org/tracker/joomla-cms/25658. Just use the button "Test this", then select your test result and then submitt that with the corresponding button.
@breisig please mark your test as successfully (how to: https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results)
@MonkeyTrainer12 We still need one more tester because @breisig is either not willing or not able to mark his test result in the issue tracker like described e.g. here #25658 (comment) or here https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results .
@breisig Thanks for your test, but please also mark your test result in the Joomla CMS issue tracker at https://issues.joomla.org/tracker/joomla-cms/25658. Just use the button "Test this", then select your test result and then submitt that with the corresponding button.
As long as not marked, it is not counted, and as long as no 2 test, this PR will not be ready for merge.
|Status||Pending||⇒||Ready to Commit|
|Status||Ready to Commit||⇒||Fixed in Code Base|
|Closed_Date||0000-00-00 00:00:00||⇒||2019-07-26 10:55:37|
Thanks to all testers and to reporters for your patience, and thanks for merging of course.