PR-staging RTC

Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
20 Jul 2019

Pull Request for Issue #25452 for staging.

Summary of Changes

Fix case in column type check of database schema checker for MySQL 8.

When you enter e.g. the SQL statement

SHOW COLUMNS IN #__extensions WHERE field = 'enabled' AND type = 'TINYINT(3)';

(using your db prefix of course and not #__)

in PhpMyAdmin on a Joomla 3.9.10 or staging database, you will get a result in MySQL 5.7 but not in MySQL 8.

But when you enter

SHOW COLUMNS IN #__extensions WHERE field = 'enabled' AND UPPER(type) = 'TINYINT(3)';

you get a result on both MySQL versions.

In both cases type names are lowercase in the result, but on MySQL 8 the search seems to be case-sensitive, while it is case-insensitive e.g. on MySQL 5.7.

Testing Instructions

  1. Install current staging using a MySQL db of version 8.0.something. After successsful finish, login on backend and go to "Extensions -> Manage -> Database".

Result: See section "Actual result" below.

  1. Apply this patch, navigate to somwhere else in backend and then back to "Extensions -> Manage -> Database".

Result: See section "Expected result" below.

Expected result

No database errors.

Actual result

Database errors shown as described in issue #25452 , but when you check in the database and the schema update SQL mentioned in the error message, you will not see any reason because the data types match in all details those set by the schema update and also those in joomla.sql.

Documentation Changes Required

None.

avatar richard67 richard67 - open - 20 Jul 2019
avatar richard67 richard67 - change - 20 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Jul 2019
Category Libraries
avatar richard67 richard67 - change - 20 Jul 2019
Title
Update MysqlChangeItem.php
Fix database schema checker for MySQL 8 on staging branch
avatar richard67 richard67 - edited - 20 Jul 2019
avatar richard67
richard67 - comment - 20 Jul 2019

@wilsonge Question: Shall I do a PR for 4.0-dev, too, or shall we wait until this is merged and then 3.9.11 will be merged to 4.0-dev?

avatar richard67
richard67 - comment - 20 Jul 2019

@MonkeyTrainer12 @breisig Please test.

@ReLater Please spread in forum people shall test this PR.

@mbabker Please review or at least notice desciption above about different behavior of "SHOW COLUMNS".

avatar richard67
richard67 - comment - 20 Jul 2019

Drone failure is javascript and so not related to this PR.

avatar richard67 richard67 - change - 20 Jul 2019
The description was changed
avatar richard67 richard67 - edited - 20 Jul 2019
avatar richard67 richard67 - change - 20 Jul 2019
The description was changed
avatar richard67 richard67 - edited - 20 Jul 2019
avatar ReLater
ReLater - comment - 20 Jul 2019

@ReLater Please spread in forum people shall test this PR.

Done. Let's see how lazy they are.

And thank you for your efforts. I "bombed" my LInux with upgrading to MySQL 8 ;-)

avatar richard67
richard67 - comment - 20 Jul 2019

yes i had struggle too

thanks god i bombed only a clone vm ;-)

avatar richard67 richard67 - change - 20 Jul 2019
Labels Added: PR-staging
avatar richard67
richard67 - comment - 20 Jul 2019

Sorry, had forgotten most important part. Fixed now.

avatar richard67
richard67 - comment - 20 Jul 2019

Grr, again mistake. Now it is really correct.

avatar breisig
breisig - comment - 20 Jul 2019

Will test out the patch very soon.

avatar richard67
richard67 - comment - 21 Jul 2019

@breisig Did you already find time to test? If so, please mark your test result in the Joomla CMS issue tracker at https://issues.joomla.org/tracker/joomla-cms/25658. Just use the button "Test this", then select your test result and then submitt that with the corresponding button.

avatar frostmakk
frostmakk - comment - 21 Jul 2019

I have tested this item successfully on 30cd879

Tested on localhost wamp J 3.9.10 , PHP 7.3.7 , MySQL 8.0.15


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25658.

avatar frostmakk frostmakk - test_item - 21 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 21 Jul 2019

@MonkeyTrainer12 @breisig One more tester only needed. Thanks @frostmakk for testing.

avatar breisig
breisig - comment - 22 Jul 2019

@richard67 It looks like it works.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 22 Jul 2019
avatar richard67
richard67 - comment - 22 Jul 2019

@MonkeyTrainer12 We still need one more tester because @breisig is either not willing or not able to mark his test result in the issue tracker like described e.g. here #25658 (comment) or here https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results .

avatar richard67
richard67 - comment - 25 Jul 2019

@breisig Thanks for your test, but please also mark your test result in the Joomla CMS issue tracker at https://issues.joomla.org/tracker/joomla-cms/25658. Just use the button "Test this", then select your test result and then submitt that with the corresponding button.

As long as not marked, it is not counted, and as long as no 2 test, this PR will not be ready for merge.

avatar breisig
breisig - comment - 25 Jul 2019

I have tested this item successfully on 30cd879

It worked for me.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25658.

avatar breisig breisig - test_item - 25 Jul 2019 - Tested successfully
avatar Quy Quy - change - 26 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25658.

avatar Quy
Quy - comment - 26 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25658.

avatar wilsonge wilsonge - change - 26 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-26 10:55:37
Closed_By wilsonge
Labels Added: RTC
avatar wilsonge wilsonge - close - 26 Jul 2019
avatar wilsonge wilsonge - merge - 26 Jul 2019
avatar wilsonge
wilsonge - comment - 26 Jul 2019

Thanks!

avatar richard67
richard67 - comment - 26 Jul 2019

Thanks to all testers and to reporters for your patience, and thanks for merging of course.

Add a Comment

Login with GitHub to post a comment