[#25642] - [4.0 Extension update - tooltip and fixes
- Fixed in Code Base
- 23 Jul 2019
- Medium
- Build: 4.0-dev
- # 25642
- Diff
- brianteeman:fri1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
While writing the code to change the tooltip with the new accessible ones it was apparent that the view was broken. The extension description would always say "no description available"
Test instructions
- Install the Persian language pack
- Go to the database and find the record in the extensions table for Persian Language Pack and then replace the contents of the manifest_cache with
{"name":"Persian Language Pack","type":"package","creationDate":"July 2019","author":"Farsi translation team, joomlafarsi.com","copyright":"Copyright (C) 2005 - 2019 Joomlafarsi.com and Open Source Matters, Inc. All rights reserved.","authorEmail":"info@joomlafarsi.com","authorUrl":"www.joomlafarsi.com","version":"3.9.10.1","description":"\n\t\t<h3>\u0641\u0627\u0631\u0633\u06cc \u0633\u0627\u0632 \u062c\u0648\u0645\u0644\u0627 3.9 \u06a9\u0627\u0631\u06cc \u0627\u0632 \u062a\u06cc\u0645 \u0628\u0631\u06af\u0632\u06cc\u062f\u0647 \u062c\u0648\u0645\u0644\u0627 \u062f\u0631 \u0627\u06cc\u0631\u0627\u0646. \u062c\u0648\u0645\u0644\u0627 \u0641\u0627\u0631\u0633\u06cc \u062f\u0627\u062a \u06a9\u0627\u0645<\/h3>\n\t\t<h3>Joomla! 3.9 Full Farsi (fa-IR) Language Package version 3.9.10v1, JoomlaFarsi.com<\/h3>\n\t\t<br>","group":"","filename":"pkg_fa-IR"} - Joomla should now see that an update is available if you go to Update-extensions and the description is shown as below
If you dont see any updates try clicking on the clear cache and find updates buttons
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
This works but the tip is in bold. Compare with the search box tip.
The tip is in "bold" because the description in the database has an H3 . That is not something from this PR. It always has been this way. I don't know why though. Am happy to look into why it is created that way but I would prefer that to be in its own PR as it will probably impact other areas
So with the tip in the H3 this is only an issue with languages and is because in the language manifest eg administrator\manifests\packages\pkg_fr-FR.xml the markup is hard coded.
<description><![CDATA[<div style="text-align:left;">
<h3>Joomla! 3.9.7 Full French (fr-FR) Language Package - Version 3.9.7.1</h3>
<h3>Paquet de langue Joomla! 3.9.7 français (fr-FR) complet - Version 3.9.7.1</h3>
</div>]]></description>
Now that I see this is why there is nothing that can be done by this PR to change it
Please note the following where name is in <label> and this PR has it in <span>. I don't know which is correct.
System > Manage > Extensions
<td class="text-center">
<label for="cb0"><span class="sr-only">Select </span></label><input type="checkbox" id="cb0" name="cid[]" value="153" onclick="Joomla.isChecked(this.checked);"> </td>
<th scope="row">
<label for="cb0" tabindex="0">
Action Log - Joomla </label>
<div role="tooltip" id="tip0">
Record the actions of users on the site for Joomla core extensions so they can be reviewed if required. </div>
</th>
System > Update > Extensions
<td class="text-center">
<label for="cb0"><span class="sr-only">Select </span></label><input type="checkbox" id="cb0" name="cid[]" value="78" onclick="Joomla.isChecked(this.checked);"> </td>
<th scope="row">
<span tabindex="0">French</span>
<div role="tooltip" id="tip0">
<div style="text-align:left;">
<h3>Joomla! 3.9.7 Full French (fr-FR) Language Package - Version 3.9.7.1</h3>
<h3>Paquet de langue Joomla! 3.9.7 français (fr-FR) complet - Version 3.9.7.1</h3>
</div> </div>
</th>
System manage is not correct. You can not have two labels for the same id
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25642.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25642.
@Quy @brianteeman Will someone make a PR to fix the duplicate label in "System > Manage > Extensions"? Or has that already be done?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25642.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-23 17:47:42 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
thanks
@richard67 Can you please submit a PR for it? Thanks.
@Quy I am not sure what to replace the label with. I can't completeley remove it. I guess it should be a div, but should it have some class? Maybe better @brianteeman does it when he does tool tips for the extensions manager view, or at least he checks and gives me advise?
@brianteeman We are talking about the duplicate label in "System > Manage > Extensions" mentioned by Quy in his comment above.
Replace with <span> same as in this PR.
If @brianteeman will make tool tips for that, he will fix it anyway.
But ok, I do that in half an hour, then it will not be forgotten.
Tooltips for that page are already fixed.
Yes I just saw when editing the file ;-) PR ready in a few minutes.
Please guys this isnt a chatroom
To test, much simpler way is to install an older language pack and then display the Update view ;)
Here for French
fr-FR_joomla_lang_full_3.9.7v1.zip
Here for Persian
fa-IR_joomla_lang_full_3.9.6v1.zip