J4 Issue ?
avatar wilsonge
wilsonge
18 Jul 2019

Despite core is dropping formal support for IE in our template neither do we want to make it too hard to build frontend templates on IE. Basically in core we can use the ES6 files natively now and we also don't want to have to add IE code in this.

I believe we can use this https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md#web-standards for the es5 files which will hopefully still be ie11 compat (but not used by core but provided as a service for templates who require it). And that will polyfill nodeList.foreach removing our requirement for example to use [].slice.call() from JS as an example

This came out of this closed issue #25566

avatar wilsonge wilsonge - open - 18 Jul 2019
avatar joomla-cms-bot joomla-cms-bot - change - 18 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jul 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 19 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 19 Jul 2019
Status New Discussion
avatar brianteeman
brianteeman - comment - 9 Apr 2021

@Fedik @dgrammatiko @wilsonge Is this still an issue?

avatar dgrammatiko
dgrammatiko - comment - 9 Apr 2021

Partially. The core-js that @wilsonge mentioned here is already in our dependencies

"core-js": "^3.9.1",
BUT the ES5 rollup config needs some attention. I mean we can inflate every script by injecting the polyfills from core-js (easy fix I already have the code muted in place) or serve the polyfills as separate scripts (with a nomodule attribute) so we don't repeat the polyfills per script. Reference: #32315 (comment)

avatar dgrammatiko
dgrammatiko - comment - 10 Apr 2021

@brianteeman this can be closed as there's a PR: #33084

avatar dgrammatiko
dgrammatiko - comment - 10 Apr 2021

This can be closed but there is still #22164 which needs to be addressed (eg polyfills not provided by babel)

@Quy @alikon

avatar joomdonation joomdonation - change - 10 Apr 2021
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2021-04-10 09:40:09
Closed_By joomdonation
avatar joomdonation joomdonation - close - 10 Apr 2021
avatar joomdonation
joomdonation - comment - 10 Apr 2021

Closing as requested. Thanks @dgrammatiko

Add a Comment

Login with GitHub to post a comment