[#25635] - [4.0] Remove unused files
- Fixed in Code Base
- 28 Jul 2019
- Medium
- Build: 4.0-dev
- # 25635
- Diff
- brianteeman:thu7
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
These files are not used in j4 and were only kept in j3 for potential b/c issues with 3pd admin templates so they can be safely deleted now.
Better to delete them than to continually keep updating them when they're not being used
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_fields com_menus com_newsfeeds com_plugins com_tags com_templates |
| Labels |
Added:
?
|
||
I have tested this item
Applied pr and played a bit on backed without noticing fault for missing files
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25635.
Please also remove
- administrator/components/com_categories/tmpl/category/edit_metadata.php
- administrator/components/com_contact/tmpl/contact/edit_metadata.php
- administrator/components/com_content/tmpl/article/edit_metadata.php
Please restore
- administrator/components/com_newsfeeds/tmpl/newsfeed/edit.php
- administrator/components/com_newsfeeds/tmpl/newsfeed/edit_associations.php
- administrator/components/com_newsfeeds/tmpl/newsfeed/edit_display.php
- administrator/components/com_newsfeeds/tmpl/newsfeed/modal.php
Looking at the associations file, that is pretty much useless. That one line can very well be moved to the main file and all that boilerplate code could be removed. Haven't looked at the other association files, but I fear they are all the same. In that case that is a bunch of files that could go as well, but maybe in a different PR.
agree but in a different pr
This PR is for unused files - another PR for changed files. Single purpose PR :)
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-28 00:30:31 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thanks
It would be great if this could be tested and merged soon. It makes life so much easier if we're not looking at or trying to fix unused views