Feeling Lucky
?
?
[#25626] - Fix field name on messages
- Fixed in Code Base
- 23 Jul 2019
- Medium
- Build: staging
- # 25626
- Diff
- degobbis:FixFormWarningLabel
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Output field label on messages/warnings if exist
Testing Instructions
- Create a custom field from the type media and disable the permission to edit custom field value for the group Manager.
- Edit in backend the article with this custom field as a super user and as an example select an image.
- Login in frontend with the user in the group Manager and edit the article with this custom field and safe it without any changes.
This will show a warning wich is a bug that I will hopfully fix with an other PR
update here is the fix #25682
Expected result
The warning shown prints the field label to define the errorfield
Actual result
The warning shown prints the field name to define the errorfield, which may be named differently from the label and therefore may not be findable
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
viocassel
- comment
- 22 Jul 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25626.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 22 Jul 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25626.
HLeithner
- comment
- 22 Jul 2019
$fieldName is a misleading name for the variable could you please change it to $fieldLabel or $messageLabel.
thx
| Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
degobbis
- comment
- 23 Jul 2019
@HLeithner changed the name from the variable to $fieldLabel
HLeithner
- comment
- 23 Jul 2019
thx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-23 08:13:00 |
| Closed_By | ⇒ | HLeithner |
I have tested this item✅ successfully on 7f96f48
Code Works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25626.