NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Jul 2019

Third redo of #21982

Removed again by #23903

avatar brianteeman brianteeman - open - 17 Jul 2019
avatar brianteeman brianteeman - change - 17 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2019
Category Administration Templates (admin)
avatar Quy
Quy - comment - 18 Jul 2019

I have tested this item successfully on d831903


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25616.

avatar Quy Quy - test_item - 18 Jul 2019 - Tested successfully
avatar wilsonge
wilsonge - comment - 24 Jul 2019

Can we make sure the calendar still renders ok as well, given that's what removed this code

avatar infograf768
infograf768 - comment - 24 Jul 2019

It does not render exactly the same:

Before:
Screen Shot 2019-07-24 at 15 21 43

After
Screen Shot 2019-07-24 at 15 21 53

The grey line is thicker below 2019 and also below June. Therefore it is slightly taller.

avatar brianteeman
brianteeman - comment - 24 Jul 2019

It would be better to fix that with specific css in /media/system/css/fields/calendar.css

I can do that here or in its own PR ??

avatar infograf768
infograf768 - comment - 24 Jul 2019

and in calendar-rtl.css

avatar brianteeman brianteeman - change - 24 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jul 2019
Category Administration Templates (admin) Administration Templates (admin) Repository NPM Change
avatar brianteeman
brianteeman - comment - 24 Jul 2019

updated both the calendar files

avatar Quy
Quy - comment - 24 Jul 2019

I have tested this item successfully on c526b04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25616.

avatar Quy
Quy - comment - 24 Jul 2019

I have tested this item successfully on c526b04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25616.

avatar Quy Quy - test_item - 24 Jul 2019 - Tested successfully
avatar Hackwar
Hackwar - comment - 24 Jul 2019

Can you update the PR to the latest 4.0-dev? Drone refuses to run due to some conflict.

avatar brianteeman brianteeman - change - 24 Jul 2019
Labels Added: NPM Resource Changed
avatar wilsonge wilsonge - change - 24 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-24 18:45:14
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Jul 2019
avatar wilsonge wilsonge - merge - 24 Jul 2019
avatar wilsonge
wilsonge - comment - 24 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 24 Jul 2019

Thnks

Add a Comment

Login with GitHub to post a comment