? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Jul 2019

This PR fixes the bug that the burger icon should be grey when sorting is disabled. (you will need to npm to build the css to test this part)

This PR updates the markup for the title text. It removes a class that was for mootools and as its just a regular title we dont need to pass the text through a helper.

After - Sorting active

image

After - Sorting inactive

image

image

avatar brianteeman brianteeman - open - 17 Jul 2019
avatar brianteeman brianteeman - change - 17 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2019
Category Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Templates (admin)
avatar brianteeman brianteeman - change - 17 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 17 Jul 2019
Category Administration com_banners com_categories com_contact com_content com_fields com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Templates (admin) Administration com_banners com_categories com_contact com_content com_fields com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_users com_workflow Templates (admin)
avatar Quy
Quy - comment - 17 Jul 2019

I have tested this item successfully on d3fb01c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25603.

avatar Quy Quy - test_item - 17 Jul 2019 - Tested successfully
avatar alikon
alikon - comment - 17 Jul 2019

I have tested this item successfully on d3fb01c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25603.

avatar alikon alikon - test_item - 17 Jul 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jul 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 23 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-23 17:53:54
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 23 Jul 2019
avatar wilsonge wilsonge - merge - 23 Jul 2019
avatar wilsonge
wilsonge - comment - 23 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 23 Jul 2019

thanks

Add a Comment

Login with GitHub to post a comment