Feeling Lucky
?
?
[#25593] - [4.0] codemirror fonts
- Fixed in Code Base
- 16 Jul 2019
- Medium
- Build: 4.0-dev
- # 25593
- Diff
- zero-24:https
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25588 thanks @brianteeman
Summary of Changes
For some reasons this commit here: 574bc41#diff-6042b20d31889b87a9357432fef2ab1a has never been merged up to 4.0-dev this here adds it back
Testing Instructions
Make sure fonts are always loaded via https
Expected result
fonts are always loaded via https
Actual result
fonts are not always loaded via https
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Labels |
Added:
?
|
||
richard67
- comment
- 16 Jul 2019
I have tested this item
Code review: PR does the same as PR #19488 did for staging, and it covers all fonts in plugins/editors/codemirror/fonts.json except of those which were already using https.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25593.
SharkyKZ
- comment
- 16 Jul 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25593.
| Status | Pending | ⇒ | Ready to Commit |
franz-wohlkoenig
- comment
- 16 Jul 2019
Status "Ready To Commit".
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-16 19:18:55 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 16 Jul 2019
Thanks!
I have tested this item✅ successfully on 414c23c
Code review: PR does the same as PR #19488 did for staging, and it covers all fonts in
plugins/editors/codemirror/fonts.jsonexcept of those which were already using https.This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25593.