? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jul 2019

Changes the font urls so they are consistent.
especially important to prevent mixed content warning etc when running on https

avatar brianteeman brianteeman - open - 16 Jul 2019
avatar brianteeman brianteeman - change - 16 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2019
Category Front End Plugins
avatar SharkyKZ
SharkyKZ - comment - 16 Jul 2019

This isn't right. If the remote site supports HTTPS, it should be used.

avatar zero-24
zero-24 - comment - 16 Jul 2019

Is there a reason to not enforce https on that links? As google fonts supports https what is the reason to downgrade to http in any case?

avatar brianteeman
brianteeman - comment - 16 Jul 2019

@zero-24 The better question would be why was http being forced

@SharkyKZ it will be

avatar zero-24
zero-24 - comment - 16 Jul 2019

@zero-24 The better question would be why was http being forced

It dates back to the inital commit: ef8c75a#diff-6042b20d31889b87a9357432fef2ab1a (22 Jul 2014)

I can't think of a real reason.

avatar SharkyKZ
SharkyKZ - comment - 16 Jul 2019

@brianteeman No, the protocol of local site (i.e. your Joomla site) would be used. HTTPS should be forced here since fonts.googleapis.com definitely supports it. Also, this needs to be done against staging.

avatar brianteeman
brianteeman - comment - 16 Jul 2019

feel free to fix it

avatar brianteeman brianteeman - change - 16 Jul 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-07-16 17:01:08
Closed_By brianteeman
Labels Added: ?
avatar brianteeman brianteeman - close - 16 Jul 2019
avatar zero-24
zero-24 - comment - 16 Jul 2019

Also, this needs to be done against staging.

hmm seams to be fixed there already to use https: https://github.com/joomla/joomla-cms/blob/staging/plugins/editors/codemirror/fonts.json

avatar zero-24
zero-24 - comment - 16 Jul 2019

feel free to fix it

Done: #25593 seams like this commit has never been merged up to 4.0-dev or overwritten for some reason: 574bc41#diff-6042b20d31889b87a9357432fef2ab1a

Add a Comment

Login with GitHub to post a comment