? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
16 Jul 2019

The notices and warning were displayed in a table. A table should never be used for display purposes and this is not tabular data.

This PR corrects that and puts the notices and warnings as divs

avatar brianteeman brianteeman - open - 16 Jul 2019
avatar brianteeman brianteeman - change - 16 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Jul 2019
Category Administration com_languages
avatar brianteeman brianteeman - change - 16 Jul 2019
Labels Added: ?
avatar brianteeman
brianteeman - comment - 16 Jul 2019

Drone errors are unrelated to this pr

avatar richard67 richard67 - test_item - 16 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 16 Jul 2019

I have tested this item successfully on ecb3964

Looks even better than before because of spacing between the divs.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25581.

ac2b7c0 17 Jul 2019 avatar brianteeman tab
avatar Quy
Quy - comment - 17 Jul 2019

I have tested this item successfully on ac2b7c0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25581.

avatar Quy Quy - test_item - 17 Jul 2019 - Tested successfully
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jul 2019

@richard67 can you please retest?

avatar Quy
Quy - comment - 17 Jul 2019

Since it is indentation only, a retest is not necessary.

avatar franz-wohlkoenig franz-wohlkoenig - change - 17 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 17 Jul 2019

Status "Ready To Commit".

avatar brianteeman brianteeman - change - 17 Jul 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 23 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-23 17:51:51
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Jul 2019
avatar wilsonge wilsonge - merge - 23 Jul 2019
avatar wilsonge
wilsonge - comment - 23 Jul 2019

Thanks!

avatar brianteeman
brianteeman - comment - 23 Jul 2019

thanks

Add a Comment

Login with GitHub to post a comment