thanks for merging

I'm a bit disappointed that I was not mentioned in the changelog thankings. @garyamort @Denitz @infograf768

I think my help was fundamental to find where the issue was, and Dennis just improved (very well) my original patch that required many hours of work to figure out the issue in the code and find a solution (deep debugging).

(I remember to you that first time the issue was marked as unresolvable as too complex to figure it out by a Joomla maintainer! See the first closing motivation of this issue: joomla/joomla-platform#673)

I could also have not shared that fix and started selling a pro plugin or service to fix that issue on BIG Joomla sites that needed cache working well, but i wanted to share my efforts to the opensource community.

Original pull request was: #2150

Can you please change that line in /installation/CHANGELOG:

"# [#26551] Multiple instances of script and css declarations with enabled caching Thanks Dennis Hermatski"
to
"# [#26551] Multiple instances of script and css declarations with enabled caching Thanks Dennis Hermatski & Stefano Gargiulo"

If no, no matters for me, but that's not "open source matters" spirit.

@creativeprogramming The changelog got retired anyway.

@Bakual what do you mean by: "The changelog got retired anyway."?

Here the line I'm talking about: https://github.com/joomla/joomla-cms/blob/master/installation/CHANGELOG#L75

@creativeprogramming We don't maintain the changelog anymore. It was decided to only use the git commit messages instead as the changelog file had to be maintained manually and didn't add much benefit over the commit messages.

@creativeprogramming please see https://groups.google.com/d/msg/joomla-dev-cms/c3R7euwS6mg/vXQo1gJZDuYJ . If I'm not mistaken, that file may need to be removed from the repository.

I am sorry that you didn't get recognized in the changelog. We do try our best to recognize everyone, but sometimes we miss people. It was an honest mistake.

Thanks @betweenbrain and @Bakual.

Now is clear.

Your reply is very appreciated and is my satisfaction about that point, it's enough, many thanks!

This can motivate me trying to contribute again in the future. Because being blind about that point I thought it was because of some "closed circle policies".

Best Regards,
And thank you all for the awesome Joomla and your efforts!
Stefano

This can motivate me trying to contribute again in the future.

That would be awesome

I'm very happy to read this Stefano. This is great motivation for us as
well. Thank you!

Best,

Matt Thomas
@betweenbrain
http://matt-thomas.me/
http://betweenbrain.com/
https://github.com/betweenbrain

Sent from mobile. Please pardon any typos or brevity.
On Dec 20, 2013 3:17 PM, "Stefano Gargiulo" notifications@github.com
wrote:

Thanks @betweenbrain https://github.com/betweenbrain and @Bakualhttps://github.com/Bakual
.

Now is clear.

Your reply is very appreciated and is my satisfaction about that point,
it's enough, many thanks!

This can motivate me trying to contribute again in the future. Because
being blind about that point I thought it was because of some "closed
circle policies".

Best Regards,
And thank you all for the awesome Joomla and your efforts!
Stefano

—
Reply to this email directly or view it on GitHub#2558 (comment)
.

@creativeprogramming I'm a bit confused on why I am listed as referencing this commit since I don't recall being involved in it at all.

My guess is you pushing to your fork the way the screen reads to me.