Feeling Lucky
?
?
?
[#25577] - [4.0] Adding checks for synced .lock files
- Fixed in Code Base
- 15 Jul 2019
- Medium
- Build: 4.0-dev
- # 25577
- Diff
- Hackwar:drone
- Success Hound No violations found. Woof! Details
- Pending continuous-integration/drone/pr Build is running Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25571.
Summary of Changes
This adds checks for composer and npm for their respective .lock files. When someone makes changes to composer.json or package.json without updating the respective .lock file, the build should fail.
Testing Instructions
Right now the repo seems to have an out-of-date composer.lock, so this should fail now. So when this fails for the right reasons, we can then update the .lock files and merge this one.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Labels |
Added:
?
?
|
||
| Category | Unit Tests | ⇒ | Unit Tests External Library Composer Change |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-15 22:55:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!