Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25574] - [4.0] Codestyle(?) fixes in 25451 breaks com_contact

J4 Issue ?
avatar brianteeman
brianteeman
15 Jul 2019

Steps to reproduce the issue

Try to go to contacts in the admin.

Expected result

Contact list loads

Actual result

If no contacts then you get the usual no records
If there are contacts then you get the error $i is not allowed to be 0

Additional comments

This is because of the changes made in #25451 by @Hackwar here

joomla-cms/administrator/components/com_contact/Service/HTML/AdministratorService.php

Lines 107 to 113 in 566252b

public function featured($value = 0, $i = 0, $canChange = true)
{
if ($i === 0)
{
throw new \InvalidArgumentException('$i is not allowed to be 0');
}

As I dont understand the code there I have not done a simple revert - although I note that contacts works as intended if reverted

avatar brianteeman brianteeman - open - 15 Jul 2019
avatar joomla-cms-bot joomla-cms-bot - change - 15 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 15 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Jul 2019
Title
…
Codestyle(?) fixes in 25451 breaks com_contact
[4.0] Codestyle(?) fixes in 25451 breaks com_contact
avatar franz-wohlkoenig franz-wohlkoenig - edited - 15 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 Jul 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 15 Jul 2019
avatar SharkyKZ
SharkyKZ - comment - 15 Jul 2019

Reverting is fine.

avatar SharkyKZ
SharkyKZ - comment - 15 Jul 2019

Test PR #25576 please.

avatar brianteeman brianteeman - change - 15 Jul 2019
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-07-15 20:10:42
Closed_By ⇒ brianteeman
avatar brianteeman brianteeman - close - 15 Jul 2019

Add a Comment

Login with GitHub to post a comment