Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25540] - [4.0] Convert plugin system privacyconsent to prepared statements

? ? Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
12 Jul 2019

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries.

Testing Instructions

Use the plugin in all ways you can think of.

Create a privacy consent form and test if it works.

Expected result

Nothing changed.

avatar HLeithner HLeithner - open - 12 Jul 2019
avatar HLeithner HLeithner - change - 12 Jul 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2019
Category ⇒ Front End Plugins
avatar HLeithner HLeithner - change - 17 Jul 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 19 Oct 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2019
Category Front End Plugins ⇒ JavaScript Repository NPM Change Front End Plugins
avatar HLeithner HLeithner - change - 19 Oct 2019
Labels Added: NPM Resource Changed
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2019
Category Front End Plugins JavaScript Repository NPM Change ⇒ Front End Plugins
avatar HLeithner HLeithner - change - 19 Oct 2019
Labels Removed: NPM Resource Changed
1231ad9 19 Oct 2019 avatar HLeithner cs
avatar HLeithner HLeithner - change - 19 Oct 2019
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 19 Oct 2019
Labels Added: ?
Removed: ?
avatar waader waader - test_item - 20 Oct 2019 - Tested unsuccessfully
avatar waader
waader - comment - 20 Oct 2019

I have tested this item ? unsuccessfully on df9ea6f

I logged in on frontend an when submitting the profil page with the privacy consent I get the error: 0 Class 'ArrayHelper' not found

Tested with postgresql.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25540.

avatar HLeithner HLeithner - change - 29 Oct 2019
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - change - 3 Nov 2019
Labels Added: ?
Removed: ?
avatar richard67
richard67 - comment - 3 Nov 2019

@waader Good find. Error has been corrected here meanwhile. Could you test again? Thanks in advance.

avatar richard67 richard67 - test_item - 3 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 3 Nov 2019

I have tested this item ✅ successfully on 72a763b

Hint for other testers: Untranslated language strings are not related to or subject of this PR.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25540.

avatar waader waader - test_item - 3 Nov 2019 - Tested successfully
avatar waader
waader - comment - 3 Nov 2019

I have tested this item ✅ successfully on 72a763b

The error has gone!

I noticed that the request for information deletion as well as export is send twice to the user. This has probably nothing to do with the work done here?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25540.

avatar richard67
richard67 - comment - 3 Nov 2019

@waader I don't think it is related to this PR.

avatar richard67 richard67 - change - 3 Nov 2019
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 3 Nov 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25540.

avatar Quy Quy - change - 3 Nov 2019
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 5 Nov 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-11-05 16:54:13
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 5 Nov 2019
avatar wilsonge wilsonge - merge - 5 Nov 2019
avatar wilsonge
wilsonge - comment - 5 Nov 2019

Thanks!

avatar wilsonge
wilsonge - comment - 5 Nov 2019

@waader can you send a separate issue in for the double email sending please?

Add a Comment

Login with GitHub to post a comment