? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
11 Jul 2019

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Create a Privacy Request in backend.

Expected result

No errors.

Actual result

Return value of Joomla\Component\Privacy\Administrator\Model\RequestModel::getActionlogModel() must be an instance of ActionlogsModelActionlog, bool returned

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 11 Jul 2019
avatar SharkyKZ SharkyKZ - change - 11 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2019
Category Administration
avatar SharkyKZ SharkyKZ - change - 11 Jul 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 11 Jul 2019
Category Administration Administration Front End
avatar SharkyKZ
SharkyKZ - comment - 11 Jul 2019

Do we need to have 5 duplicate methods here or could we just add 1 to some helper instead?

avatar mbabker
mbabker - comment - 11 Jul 2019

Do we need to have 5 duplicate methods here or could we just add 1 to some helper instead?

They are 5 separate contexts, it is fine as is. Trying to DRY this code for the sake of it is going to result in awkward public facing API.

avatar wilsonge wilsonge - change - 12 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-12 13:16:58
Closed_By wilsonge
avatar wilsonge wilsonge - close - 12 Jul 2019
avatar wilsonge wilsonge - merge - 12 Jul 2019
avatar wilsonge
wilsonge - comment - 12 Jul 2019

Thanks!

Add a Comment

Login with GitHub to post a comment