[#25502] - [4.0] Remove behavior.tabstate
- Fixed in Code Base
- 25 Nov 2019
- Medium
- Build: 4.0-dev
- # 25502
- Diff
- brianteeman:wed5
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
As confirmed #25359 (comment) this line does nothing as the files have been removed
It hasn't been marked as deprecated in Joomla 3 - should it be #25359 (comment)
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_config com_contact com_csp com_fields com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users Front End com_content Libraries |
| Labels |
Added:
?
|
||
I have tested this item
Test OK
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25502.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25502.
@brianteeman Please fix conflicts.
| Labels |
Added:
Conflicting Files
?
|
||
conflicts resolved
It should be deprecated yup
So if I mark it as deprecated in staging will this be merged ?
Do it to 3.10-dev but yes
| Labels |
Removed:
Conflicting Files
|
||
Shouldn't the method be removed?
@brianteeman deprecation notice has been merged through so can we just remove the method from this PR please
| Category | Administration com_admin com_banners com_config com_contact com_csp com_fields com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users Front End com_content Libraries | ⇒ | Administration com_admin com_banners com_config com_contact com_csp com_fields com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users Front End com_content |
Sorry my message was ambiguous. I meant remove the function outright. If this is all the uses and it's deprecated remove the empty function from the behaviour.php file
| Category | Administration com_admin com_banners com_config com_contact com_csp com_fields com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users Front End com_content | ⇒ | Administration com_admin com_banners com_config com_contact com_csp com_fields com_finder com_installer com_languages com_menus com_modules com_newsfeeds com_plugins com_tags com_templates com_users Front End com_content Libraries |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-25 15:58:51 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Thanks - got there in the end
I have tested this item✅ successfully on 74ed964
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25502.