[#2548] - Error 404 when leaving K2 config box
- Closed
- 2 Dec 2013
- Medium
- Build: master
- # 2548
- Diff
- colivier:patch-1
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
The function getWord deletes all digits from the variable and it is a problem for some components like k2 (ex : index.php?option=com_k).
Thanks for taking the time to create and submit this pull request.
I have confirmed the issue and the pull request tests good for me. Changing getWord to getVar seems like a reasonable solution.
Actually, getVar() doesn't exist and defaults to getString(), leaving us with almost unfiltered input.
What we really want is getCmd() or just get() (which is what we use in other places for getting the component) which defaults to getCmd().
Can you change that?
Thanks for your comment and of course I understood. I would like to change the PR but I don't know the method to do that :(
Hi coliver,
I would like to change the PR but I don't know the method to do that :(
You can do the following:
1) open here your patch: https://github.com/colivier/joomla-cms/tree/patch-1
2) commit your changes in this branche :) (This mean edit the file and make the changes)
Thanks :)
Go to https://github.com/colivier/joomla-cms/edit/patch-1/administrator/components/com_config/controller/component/cancel.php and make the change. The PR will automatically update.
Thanks Thomas and zeo-24 for your help
Looks great to me!
infograf768
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2013-12-02 08:46:17 |
| Labels |
Added:
?
|
||
garyamort
-
Tracker item at http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=32741&start=0