[#25472] - Load global admin language file in Editors-XTD modals
- Closed
- 8 Jul 2019
- Medium
- Build: staging
- # 25472
- Diff
- SharkyKZ:j3/editorsXtdLang
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25344 .
Summary of Changes
Loads global administrator language file when viewing backend view in frontend (i.e. in Editors-XTD modals).
Testing Instructions
Enable Debug Language in Global Configuration.
Edit an article in frontend.
In editor, use Contact, Field and Article buttons.
Expected result
No untranslated strings.
Actual result
Untranslated strings:
# JROOT\libraries\src\Language\Text.php
JAUTHOR_ASC="ASC"
JAUTHOR_DESC="DESC"
JCATEGORY_ASC="ASC"
JCATEGORY_DESC="DESC"
JDATE_ASC="ASC"
JDATE_DESC="DESC"
JFEATURED_ASC="ASC"
JFEATURED_DESC="DESC"
JGLOBAL_HITS_ASC="HITS ASC"
JGLOBAL_HITS_DESC="HITS DESC"
JGLOBAL_LIST_ALIAS="LIST ALIAS"
JGLOBAL_LIST_ALIAS_NOTE="LIST ALIAS NOTE"
JGLOBAL_SORT_BY="SORT BY"
JGLOBAL_TITLE_ASC="TITLE ASC"
JGLOBAL_TITLE_DESC="TITLE DESC"
JGRID_HEADING_ACCESS_ASC="HEADING ACCESS ASC"
JGRID_HEADING_ACCESS_DESC="HEADING ACCESS DESC"
JGRID_HEADING_ID_ASC="HEADING ID ASC"
JGRID_HEADING_ID_DESC="HEADING ID DESC"
JGRID_HEADING_LANGUAGE_ASC="HEADING LANGUAGE ASC"
JGRID_HEADING_LANGUAGE_DESC="HEADING LANGUAGE DESC"
JGRID_HEADING_ORDERING_ASC="HEADING ORDERING ASC"
JGRID_HEADING_ORDERING_DESC="HEADING ORDERING DESC"
JSTATUS_ASC="ASC"
JSTATUS_DESC="DESC"
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact com_content com_fields |
| Labels |
Added:
?
|
||
Hmm
I tested. It looks that there is no impact doing it this way for these modals.
**Loaded** : JROOT/language/en-GB/en-GB.ini
**Loaded** : JROOT/administrator/language/en-GB/en-GB.ini
Only possible issue would be for TTs providing only frontend translation.
Any way to change the loading order?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25472.
Any way to change the loading order?
I don't think so. Global language file is first loaded very early.
Re-started drone
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25472.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25472.
IMHO, this is not the solution.
We may have different values in site xx-XX.ini and admin xx-XX.ini for the same constant.The only correct solution is to add all missing lang strings in frontend (I know it is a pain).
agree
We do not need to load admin main ini when the strings are added in frontend.
My patch will therefore delete these calls.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-08 16:32:15 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
IMHO, this is not the solution.
We may have different values in site xx-XX.ini and admin xx-XX.ini for the same constant.
The only correct solution is to add all missing lang strings in frontend (I know it is a pain).