[#25459] - [4.0] Codestyle fixes for new CMS codestyle Batch 8/16?
- Fixed in Code Base
- 11 Jul 2019
- Medium
- Build: 4.0-dev
- # 25459
- Diff
- Hackwar:j4test_codestyle_fixes8
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
We have a long-tested codestyle for the CMS which we hesitated so far to adopt. The new codestyle is a lot stricter and this results in several errors.
To finally adopt this new codestyle, #25447 sets up our CI system to run both the old and the new codestyle in parallel. This PR is the eigth PR in a series to patch the codestyle 20 files at a time. There should be 319 files with issues. All PRs will be based on each other to finally have a passing PR. I guess the best solution would be to wait until I'm done and then go through these PRs starting with #25447 and merge them one by one. The prior PR is #25458
This PR removes the old codestyle rules and phpcs step from drone, since the changes in this PR fail on the old styles, but pass on the new ones.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Administration com_admin com_associations com_banners com_categories com_config com_contact com_content |
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Administration com_admin com_associations com_banners com_categories com_config com_contact com_content | ⇒ | Unit Tests Administration com_installer com_newsfeeds com_redirect Repository Layout Libraries |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-11 21:42:35 |
| Closed_By | ⇒ | wilsonge |
Thanks!