? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
6 Jul 2019

Pull Request for Issue #24605.

Summary of Changes

Add prefix to class name to prevent conflicting with existing classes.

Testing Instructions

Create a new Menu named Hidden and set the menutype to "hidden".
Add a menu item to that menu.
Open a template style and check the Menu Assignment tab.

Expected result

A visible checkbox to associate the template style with the created menu item.

Actual result

No checkbox visible. Reason for that is the menu alias will be added to the Input tag as a class - without any prefix. So it becomes input[type=checkbox].hidden which is a class used by bootstrap to hide stuff.

avatar Quy Quy - open - 6 Jul 2019
avatar Quy Quy - change - 6 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Jul 2019
Category Administration com_templates
avatar Quy Quy - change - 6 Jul 2019
Title
Add prefix to class name
[com_templates] Add prefix to class name in menu assignment
avatar Quy Quy - edited - 6 Jul 2019
avatar Quy Quy - change - 6 Jul 2019
The description was changed
avatar Quy Quy - edited - 6 Jul 2019
avatar richard67 richard67 - test_item - 6 Jul 2019 - Tested successfully
avatar richard67
richard67 - comment - 6 Jul 2019

I have tested this item successfully on 06acd66


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454.

avatar richard67
richard67 - comment - 6 Jul 2019

I have tested this item successfully on 06acd66


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454.

avatar SharkyKZ
SharkyKZ - comment - 6 Jul 2019

I have tested this item successfully on 06acd66


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454.

avatar SharkyKZ SharkyKZ - test_item - 6 Jul 2019 - Tested successfully
avatar Quy Quy - change - 6 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 6 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25454.

avatar HLeithner HLeithner - change - 20 Jul 2019
Labels Added: ? ?
avatar HLeithner HLeithner - change - 20 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-20 19:00:10
Closed_By HLeithner
avatar HLeithner HLeithner - close - 20 Jul 2019
avatar HLeithner HLeithner - merge - 20 Jul 2019
avatar HLeithner
HLeithner - comment - 20 Jul 2019

thx

Add a Comment

Login with GitHub to post a comment