[#25442] - [4.0] Can't search redirects
- Fixed in Code Base
- 10 Jul 2019
- Medium
- Build: 4.0-dev
- # 25442
- Diff
- SharkyKZ:j4/redirectSearch
- Pending Hound Hound is busy sniffing around... Details
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25429.
Summary of Changes
Removes required attribute from a field.
Testing Instructions
Go to Redirects.
Search for keywords.
Expected result
Form submitted.
Actual result
Form not submitted, "Please fill out this field." prompt is shown by browser.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_redirect |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25442.
| Status | Pending | ⇒ | Ready to Commit |
Status "Ready To Commit".
@HLeithner @wilsonge so its ok to remove the required field here but not where it actually makes sense for the form to remove required fields?
@brianteeman, here the attribute only exists in HTML markup, not in XML form definition. It can only perform client-side validation. Your concern relates to uses that affect server-side validation. This is something that needs to be a addressed on a case-by-case basis.
And it's not. It's arbitrary and inconsistent
Well the correct solution to this is that batch should be a separate form. And this should be required in that form. My guess is that this is the only place in the CMS where this is the only field (and by proxy required in a batch form)
Can someone check if there are any other places where batch is a separate form? If there's not we can remove this temporarily and try and refactor batch in another PR so we can reintroduce it. If there is already places were we have separate batch forms then let's get it right first time :)
this is the only place. I guess it was created at a later date to the bulk import as that uses the batch ;(
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-10 09:36:24 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 338f033
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25442.