? ? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
5 Jul 2019

Pull Request for Issue #25344

Summary of Changes

Adding missing strings for article alias

Before patch

Screen Shot 2019-07-05 at 07 44 32

After patch

Screen Shot 2019-07-05 at 08 16 08

avatar infograf768 infograf768 - open - 5 Jul 2019
avatar infograf768 infograf768 - change - 5 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Jul 2019
Category Language & Strings
avatar infograf768
infograf768 - comment - 5 Jul 2019

Note: Imho we should solve in another way the apparently missing Sorting strings when debug lang on for Contact, Article and Field as these are no use in the modals.

avatar infograf768
infograf768 - comment - 5 Jul 2019

@HLeitner
We should consider this for 3.9.9 imho. We will manage with TTs.

avatar SharkyKZ
SharkyKZ - comment - 5 Jul 2019

Just realized the sorting is used. We just can't see it in the modal because it has hidden-phone class applied. I'm certain this is not intentional.

avatar infograf768
infograf768 - comment - 5 Jul 2019

Not sure it is related to hidden-phone

avatar brianteeman
brianteeman - comment - 5 Jul 2019

It is the hidden-phone hidden-tablet in the layout - so if you override the layout or use a template that doesnt have those classes it will display with the missing strings of course

This is why I wrote #25344 (comment)

image

avatar infograf768 infograf768 - change - 5 Jul 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-07-05 06:46:10
Closed_By infograf768
Labels Added: ? ?
avatar infograf768 infograf768 - close - 5 Jul 2019
avatar infograf768
infograf768 - comment - 5 Jul 2019

As you know better, of course, please make patch.
(I did not find what has to be modified to display the sort fields)

avatar brianteeman
brianteeman - comment - 5 Jul 2019

Stop with the personal comments - its really pathetic

<div class="js-stools-container-list hidden-phone hidden-tablet">
<?php echo $this->sublayout('list', $data); ?>
</div>

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 5 Jul 2019

please all focus on Issue, thanks.

Add a Comment

Login with GitHub to post a comment