[#25433] - [4.0] [plg_sampledata_multilang] Convert to prepared statement
- Fixed in Code Base
- 27 Aug 2019
- Medium
- Build: 4.0-dev
- # 25433
- Diff
- HLeithner:prepared-plg-sampledata-multilang
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Updated SQL queries to prepared statements and made some cleanups around the queries.
Testing Instructions
Use the plugin in all ways you can think of.
Install multilang sampledata
Expected result
Nothing changed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Front End Plugins |
franz-wohlkoenig
- | Title |
|
||||||
| Labels |
Added:
?
?
|
||
| Category | Unit Tests Front End Plugins | ⇒ | Front End Plugins |
1st attempt:
There is an error in a sample data plugin. Response is invalid.
2nd attempt:
Step 4: Failed creating the Main menu (en-GB).
Nothing in PHP error log.
This requires joomla-framework/database#162 too... maybe this is the problem.
Works without the PR.
How to apply the database PR?
Here is step 4 which corresponds with the code that uses bindArray.
Step 4: Specific Main Menus have been created as well as associated 'List All Categories' menu items!
Apply this file https://github.com/joomla-framework/database/pull/162.diff to the libaries/vendor folder should do it
@HLeithner
Using https://github.com/joomla-framework/database/pull/162.diff solves issues here (tested with mysqli)
| Labels |
Removed:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25433.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25433.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25433.
| Labels |
Added:
?
|
||
FILE: /********/src/plugins/sampledata/multilang/multilang.php
38 | ----------------------------------------------------------------------
39 | FOUND 3 ERRORS AFFECTING 2 LINES
40 | ----------------------------------------------------------------------
41 | 926 \| ERROR \| [x] Multi-line function call not indented correctly;
42 | \| \| expected 20 spaces but found 16. Note: the
43 | \| \| autofixer will convert spaces to tabs
44 | \| \| (PEAR.Functions.FunctionCallSignature.Indent)
45 | 926 \| ERROR \| [x] Multi-line function call not indented correctly;
46 | \| \| expected 20 spaces but found 16. Note: the
47 | \| \| autofixer will convert spaces to tabs
48 | \| \| (PEAR.Functions.FunctionCallSignature.Indent)
49 | 927 \| ERROR \| [x] Closing parenthesis of a multi-line function call
50 | \| \| must be on a line by itself
51 | \| \| (PEAR.Functions.FunctionCallSignature.CloseBracketLine)
52 | ----------------------------------------------------------------------
53 | PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
54 | ----------------------------------------------------------------------
55
We need a new test here please.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25433.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25433.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-08-27 15:23:03 |
| Closed_By | ⇒ | HLeithner |
again - looks like two unrelated files here