? ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
3 Jul 2019

Summary of Changes

use prepared statement for SQL

Testing Instructions

test com_redirect

Expected result

should work as before

Actual result

N/A

avatar alikon alikon - open - 3 Jul 2019
avatar alikon alikon - change - 3 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Jul 2019
Category Administration com_redirect
avatar alikon alikon - change - 3 Jul 2019
Labels Added: ?
avatar richard67
richard67 - comment - 3 Jul 2019

com_predirect? Is it a predictive redirect component? (joking about typo in title of this PR).

avatar alikon
alikon - comment - 3 Jul 2019

happy to see that even a draft + work in progress pull request got audience 😃

avatar alikon alikon - change - 3 Jul 2019
Title
[4.0][com_predirect][wip] convert to prepared statement
[4.0][com_redirect][wip] convert to prepared statement
avatar alikon alikon - edited - 3 Jul 2019
avatar alikon alikon - change - 3 Jul 2019
Title
[4.0][com_redirect][wip] convert to prepared statement
[4.0][com_redirect] convert to prepared statement
avatar alikon alikon - edited - 3 Jul 2019
avatar Quy
Quy - comment - 3 Jul 2019

Column count doesn't match value count at row 1

68cc7e9 4 Jul 2019 avatar alikon fix
avatar Quy Quy - test_item - 4 Jul 2019 - Tested successfully
avatar Quy
Quy - comment - 4 Jul 2019

I have tested this item ✅ successfully on 72d6ef4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25417.

avatar tonypartridge
tonypartridge - comment - 13 Jul 2019

I have tested this item ✅ successfully on 72d6ef4

Working as before.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25417.

avatar tonypartridge tonypartridge - test_item - 13 Jul 2019 - Tested successfully
avatar franz-wohlkoenig franz-wohlkoenig - change - 13 Jul 2019
Status Pending Ready to Commit
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Jul 2019

Status "Ready To Commit".

avatar wilsonge wilsonge - change - 15 Jul 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 15 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-15 23:42:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Jul 2019
avatar wilsonge wilsonge - merge - 15 Jul 2019
avatar wilsonge
wilsonge - comment - 15 Jul 2019

Thanks!

Add a Comment

Login with GitHub to post a comment