? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
2 Jul 2019

Summary

This patch both fixes the query (fixing the case where the archived filter is null) and adds error handling so the fatal error can't happen again (see the part in contact model) even if we manage to reintroduce this bug and instead adds a happy error message.

Testing Instructions

Create a contact in the frontend and try and submit a contact. Before you get a fatal error in JRegistry. After patch contact submission successfully sends.

avatar wilsonge wilsonge - open - 2 Jul 2019
avatar wilsonge wilsonge - change - 2 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jul 2019
Category Front End com_contact
avatar wilsonge wilsonge - change - 2 Jul 2019
The description was changed
avatar wilsonge wilsonge - edited - 2 Jul 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Jul 2019
Title
Fix contact submission query
[4.0] Fix contact submission query
avatar franz-wohlkoenig franz-wohlkoenig - edited - 3 Jul 2019
avatar alikon
alikon - comment - 3 Jul 2019

@wilsonge as you already are on it, can you fix my prevoius mistake from #24965 on

$query->whereIn($db->quoteName('a.language'), $language);

from
$query->whereIn($db->quoteName('a.language'), $language);
to

$query->whereIn($db->quoteName('a.language'), $language, ParameterType::STRING);

avatar wilsonge wilsonge - change - 3 Jul 2019
Labels Added: ?
avatar HLeithner
HLeithner - comment - 3 Jul 2019

Thx

avatar HLeithner HLeithner - change - 3 Jul 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-03 20:45:21
Closed_By HLeithner
avatar HLeithner HLeithner - close - 3 Jul 2019
avatar HLeithner HLeithner - merge - 3 Jul 2019

Add a Comment

Login with GitHub to post a comment