[#25400] - [4.0] Featured icon display
- Fixed in Code Base
- 3 Jul 2019
- Medium
- Build: 4.0-dev
- # 25400
- Diff
- brianteeman:tue2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
If you have a user who does not have core.edit.state permissions for com_content.article then the icon displayed for "featured/unfeatured" is wrong and you cannot differentiate between "featured/unfeatured" .
The problem is that the style comes from the tbody-icon on the button and the code in the joomla.icons.action-button layout has two bugs.
The first bug is that disabled was in the class attribute - it should be its own attribute. This meant that the button was never disabled. Which is probably why the second bug was introduced - the entire if(!empty($disabled)) test is not required and because it is not wrapped in a button it never gets the tbody-icon class and looks wrong
Testing instructions
Create a new user at the manager level. In article options change the permissions for manager so that Edit State is disabled.
Login as that user and go to the list of articles.
Before PR
After PR
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25400.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25400.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-03 15:46:37 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
Thanks
I have tested this item✅ successfully on e2779df
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25400.